Skip to content

test: Remove arrow functions from mocha functions - #283

Merged
kadler merged 2 commits into
masterfrom
switch-tests-to-arrow-functions
Jun 11, 2020
Merged

test: Remove arrow functions from mocha functions#283
kadler merged 2 commits into
masterfrom
switch-tests-to-arrow-functions

Conversation

@abmusse

Copy link
Copy Markdown
Member

Resolves#200

@abmusse
abmusse marked this pull request as ready for review May 14, 2020 16:12
@abmusse
abmusse requested a review from kadlerMay 14, 2020 16:12
@abmusseabmusse changed the title test: Switch tests to arrow functionstest: Remove arrow functions from mocha functionsMay 14, 2020
@abmusse
abmusseforce-pushed the switch-tests-to-arrow-functions branch 2 times, most recently from 328df87 to 238a3e6CompareMay 14, 2020 16:56
Comment threadtest/functional/CommandCallFunctional.js Outdated
@abmusse
abmusseforce-pushed the switch-tests-to-arrow-functions branch from 3c202e7 to 241ef8fCompareJune 11, 2020 00:26
Comment thread.eslintrc.js
@abmusse

Copy link
Copy Markdown
MemberAuthor

@kadler I've cleaned up the conflicts and rebased on top of master.

@kadlerkadler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kadler
kadler merged commit 9cb7543 into masterJun 11, 2020
@kadler
kadler deleted the switch-tests-to-arrow-functions branch June 11, 2020 01:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch tests from arrow functions

2 participants

@abmusse@kadler