Uh oh!
There was an error while loading. Please reload this page.
Docs: Reference alternate XML parser - #345
Merged
Merged
Conversation
abmusse
self-requested a review
October 13, 2022 21:41
abmusse
reviewed
Oct 13, 2022
abmusse
commented
Oct 20, 2022
Member
Can you sign-off the commits to appease the DCO bot https://github.com/IBM/nodejs-itoolkit/pull/345/checks?check_run_id=7364528303 Thanks again! |
Signed-off-by: Wyatt Teeter <teeterwyatt@gmail.com> Signed-off-by: xWyatt <wteeter@ppi-global.com>
…uide Signed-off-by: Wyatt Teeter <teeterwyatt@gmail.com> Signed-off-by: xWyatt <wteeter@ppi-global.com>
Signed-off-by: Wyatt Teeter <teeterwyatt@gmail.com> Signed-off-by: xWyatt <wteeter@ppi-global.com>
Signed-off-by: Wyatt Teeter <teeterwyatt@gmail.com> Signed-off-by: xWyatt <wteeter@ppi-global.com>
xWyattforce-pushed
the
chore/docsReferenceAltXMLParser
branch
from
October 21, 2022 20:45
a16102a to
99bcf95ComparexWyatt
commented
Oct 21, 2022
ContributorAuthor
I tacked on sign-offs with my Github username to the commits as opposed to my profile name. That should appease the DCO bot - interesting that it won't accept the profile name in the first place though... |
abmusse
self-requested a review
October 26, 2022 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates documentation, documentation code samples, and the
xmlToJsondeprecation message to suggest the use offast-xml-parseroverxml2js.Previous issues, confusion, and lack of maintenance of
xml2jsoutlined in #344 lead to this PR.