test(transport): in-process certificates for the gRPC channel-factory tests (fifth readiness flake) - #347
Merged
Conversation
…rocess, not via openssl Fifth readiness-flake signature, caught by the readiness run on #342's branch (Windows lane): DefaultGrpcChannelFactoryGapCoverageTests.CreateTempCertificates shelled out to openssl three times with 10 s caps and asserted WaitForExit - the same pattern PR #335 removed from its sibling AgentTransportServiceImplReflectionGapCoverageTests. Now CertificateRequest + RSA export PEM/PKCS8/PFX in-process; same files, same shape. 7/7 tests in 0.5 s. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production-readiness audit, H10 follow-up (fifth flake signature).
The readiness run on #342's branch failed on the Windows lane in
DefaultGrpcChannelFactoryGapCoverageTests.CreateTempCertificates—opensslshell-outs with 10 s caps, exactly the pattern #335 fixed in the siblingAgentTransportServiceImplReflectionGapCoverageTests. This class was not in H10's list. It has also failed on master before (run 31982502428).Certificates are now generated in-process with
CertificateRequest+ RSA PEM/PKCS8/PFX exports; same files (cert.pem, PKCS#1key.pem,key.pk8.pem,ca.pem, passwordlessclient.pfx), same tuple.Nexo.Tests.Transportbuilds clean; the seven tests in the class pass in 0.5 s locally (were 10 s+ each when openssl was slow).Signature for future matching:
Expected boolean to be True, but found FalseatCreateTempCertificatesline ~219 inDefaultGrpcChannelFactoryGapCoverageTests.