fix: restore master CI after LiveExtenderCertLoopIntegrationTests compile errors - #519
Merged
Merged
Conversation
…ndAgents APIs Fixes compile errors in LiveExtenderCertLoopIntegrationTests.cs after #518: 1. Replace ManualAgentScheduler with AgentScheduler(ScheduleExecutor) 2. Change Parameters from Dictionary<string,string> to Dictionary<string,object> 3. Update RegisterAsync to RegisterAuthoredAsync(GenericAgent(BuildSpec(config), logger), config) 4. Fix ChangeProposalStore.Add to use ChangeProposal record pattern with Id, TargetPath, NewContent, Summary, CreatedAt, AgentId Preserves canary pass/fail test intent from #512. No production changes. Restores green perf-gate on master after c748176. Co-authored-by: IanFrelinger <IanFrelinger@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
cursorBot
pushed a commit
that referenced
this pull request
Sep 6, 2026
Co-authored-by: IanFrelinger <IanFrelinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes compile errors in
LiveExtenderCertLoopIntegrationTests.csintroduced when #512 landed with test code written against stale BackgroundAgents/Forge APIs. PR #518 only fixed theISelfExtendRunner.RunAsync(repoRoot, ct)gap; this PR completes the fix.Restores green
perf-gateon master (currently failing at c748176 / run 34005069873).Changes
ManualAgentSchedulerwithAgentScheduler(new ScheduleExecutor())(matches pattern inSelfExtendParameterFlowTests)ParametersfromDictionary<string,string>toDictionary<string,object>(current API signature)RegisterAsync(config)toRegisterAuthoredAsync(new GenericAgent(BuildSpec(config), logger), config)with proper importsChangeProposalStore.Addto useChangeProposalrecord pattern:forge.Add(new ChangeProposal { Id, TargetPath, NewContent, Summary, CreatedAt, AgentId })thenproposalIds.Add(proposal.Id)(matchesM1EnforcementTests.Parkpattern)BuildSpechelper method to construct agent specificationsTesting
Local verification
dotnet build src/Ashlar.Tests.BackgroundAgents/Ashlar.Tests.BackgroundAgents.csproj✅ compiles with 0 errors (was previously failing with 5 compile errors)Testing strategy (blast radius)
make kernel-coverage-gate(not applicable - BackgroundAgents tests only)make kernel-gate(not applicable)make test-prod-style(not applicable - test-only changes)Test intent from #512 preserved: proves canary pass/fail paths work fail-closed on live extender cert-loop integration.
Checklist
make testpasses locally (test file compiles)TODOorNotImplementedExceptionleft unresolvedRelease (only when this PR ships a versioned NuGet/GHCR release)