fix: make default adapters respect ASHLAR_ALLOW_MOCK=1 for CI gates - #522
Merged
Conversation
DefaultDeterministicStageExecutionAdapter and DefaultAgenticStageExecutionAdapter now check ASHLAR_ALLOW_MOCK=1 and return success when set, allowing perf/ship gates to run without real adapter implementations. Fail-closed behavior preserved when ASHLAR_ALLOW_MOCK is unset or not "1". Fixes perf-gate-tier-b.sh on master. Co-authored-by: IanFrelinger <IanFrelinger@users.noreply.github.com>
cursorBotforce-pushed
the
cursor/fix-perf-gate-mock-adapter-c55d
branch
from
September 6, 2026 02:31
baa28e1 to
cb9b083CompareAdd inline comment explaining ASHLAR_ALLOW_MOCK=1 CI test hook. Also ensures perf-gate.yml path filter triggers to validate the adapter fix. Co-authored-by: IanFrelinger <IanFrelinger@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
cursorBot
pushed a commit
that referenced
this pull request
Sep 6, 2026
Co-authored-by: IanFrelinger <IanFrelinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes perf-gate-tier-b failure on master by making
DefaultDeterministicStageExecutionAdapterandDefaultAgenticStageExecutionAdapterrespect theASHLAR_ALLOW_MOCK=1environment variable.Root Cause
The perf-gate script runs with
ASHLAR_ALLOW_MOCK=1to test pipeline throughput with mocked stages, but the default adapters were unconditionally returningSucceeded=false, causing the CLI to exit with code 2.Changes
ASHLAR_ALLOW_MOCK=1and returns success when set (CI-only test hook)ASHLAR_ALLOW_MOCKis unset or not "1"Verification
Resolves failing CI check at https://github.com/IanFrelinger/Ashlar/actions/runs/34006100184