feat: add download preflight and settings polish - #3
Merged
Conversation
IchenDEV
marked this pull request as ready for review
August 13, 2026 03:52
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
select-filesubmissionWhy
Kite supported many download protocols and policies, but its manual task flow committed work before users could inspect resolved metadata or container contents. Settings also mixed persistence and restart behavior, while several global actions could retain hidden selection state.
This change introduces a pre-commit staging layer, makes settings persistence explicit, and closes the highest-risk interaction inconsistencies found during the product comparison.
User impact
Users can inspect and select download inputs before creating a task, including choosing files inside Torrent/Metalink containers. Settings save automatically and clearly indicate when the engine must restart. Destructive actions and cross-section selection now behave consistently.
Notable hardening
Validation
swift test: 45 tests across 15 suites passed./script/build_and_run.sh --verify./script/build_and_run.sh --packagecodesign --verify --deep --strict --verbose=2 dist/Kite.appplutil -lint Resources/zh-Hans.lproj/Localizable.stringsbash -n script/build_and_run.shgit diff --checkRemaining scope
The gap analysis keeps media rendition preview, cURL/page collection, Settings-wide validation/search, archive password/multipart workflows, browser pairing health, and notarized public distribution as follow-up work.