Improve model download and runtime management - #69
Merged
Conversation
IchenDEV
marked this pull request as ready for review
July 29, 2026 16:58
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Model loading and runtime preparation previously doubled as download entry points. That made repeated requests capable of starting duplicate traffic, made startup or first use unexpectedly download large assets, and blurred the difference between downloading, compiling, and loading. Partial directories were also easy to mistake for complete models, while low-level errors did not tell users how to recover.
User impact
Downloads now start only after confirmation that shows the estimated remaining data and destination. A single in-flight task owns each model download, partial files are retained for resume, and the model page exposes clear progress and cancellation controls. Runtime preparation follows the same explicit lifecycle, and failures explain both the current state and the next action.
Validation
swift test: 479 XCTest tests passed, 7 environment-dependent tests skipped, 0 failuresbash scripts/ci-basic-checks.shbash scripts/build-app.sh: Release app, signing, and DMG assembly succeededmainand reran the full suite after resolving overlapping translation/model-management refactors