fix(web,mobile): replace native title tooltips, fix stale interaction-mode test - #10
Open
InM1nd wants to merge 1 commit into
Open
fix(web,mobile): replace native title tooltips, fix stale interaction-mode test#10InM1nd wants to merge 1 commit into
InM1nd wants to merge 1 commit into
Conversation
…-mode test Replaces the native `title` attribute with the Tooltip/TooltipTrigger/ TooltipPopup components in the workspace-scope-mismatch warning, the quiet board-badge list, and the thread provider icon label, satisfying the no-native-title-tooltip lint rule (4 CI lint errors). Updates legacy-plan-mode.test.ts's fallback-mode assertions from "default" to "build": DEFAULT_PROVIDER_INTERACTION_MODE was changed from "default" to "build" without updating this test, so 3 of its 4 cases asserted the wrong literal despite their titles already saying "build mode". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
titleattribute withTooltip/TooltipTrigger/TooltipPopupin the workspace-scope-mismatch warning, the quiet board-badge list, and the thread provider icon label — fixes the 4no-native-title-tooltiplint errors failing theCheckCI job.legacy-plan-mode.test.ts: 3 of 4 assertions checked.toBe("default")butDEFAULT_PROVIDER_INTERACTION_MODEis"build"(their own test titles already said "build mode") — stale since the constant's value changed. Updated the assertions to"build".Not in scope
CI's
Deploy T3 Connect relayjob fails onAXIOM_TOKENmissing from this fork's secrets — unrelated to app code, left alone.6 pre-existing web test failures (composer-logic, composerDraftStore, themeBoot, themePalette, threadRollover, ChatView.logic) already fail on main before this branch — confirmed via a clean main checkout — and are unrelated to these files.
Test plan
vp lint— 0 errors (was 4)vp test run apps/mobile/src/features/threads/legacy-plan-mode.test.ts— 4/4 passedvp run --filter @t3tools/web typecheck— cleanCo-Authored-By: Claude Sonnet 5 noreply@anthropic.com