Uh oh!
There was an error while loading. Please reload this page.
feat(triton): add JIT backend with add operator - #800
Conversation
add operator 57b7c00 to
f615a7fCompare
voltjia
left a comment
There was a problem hiding this comment.
代码需要遵循 CONTRIBUTING.md,其中 C++ 主要是遵循 Google C++ Style Guide。目前的 naming 之类的好像没有 follow 这些 convention,需要修改一下。
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
f615a7f to
47b5652Compare* refactor(triton): simplify JIT backend architecture * refactor: simplify Triton auto-tuning config * refactor: minimize Triton JIT operator API * docs: remove Triton version constraint * refactor: simplify Triton scalar validation * refactor: separate Triton platform registration * refactor: combine Triton Add registration * style: format Triton JIT headers
0c73a9e to
2df6d88CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Addoperator JIT implementation (implementation_index=7) viasrc/triton/ops/add/jit.hscripts/generate_wrappers.py, detects ops usingconfig_tand emitsconfigparameter with inline config-dict parsingsrc/CMakeLists.txt, compiles JIT infra (jit.cc/compiler.cc) and linkspybind11::embedsrc/config.h,Config::set_extension/extension()for attaching opaque extension dataMotivation
Support JIT compilation for Triton operators. Kernel caching, config passing, and autotune orchestration are implemented in C++. The compilation step bridges to
triton.compileviapybind11::embed.Closes N/A
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Full `pytest` output (optional)
Benchmark / Performance Impact
N/A
Notes for Reviewers
feat/triton-backendand depends on them being merged first.generate_wrappers.pyhas additions:_uses_config_extensionfor detecting ops withconfig_t,_generate_triton_jit_config_parserfor emitting inline config-dict parsing, and conditionaluses_configpath in_generate_call.Configclass (src/config.h) now has astd::shared_ptr<Config> extension_member withset_extension/extensionaccessors, used to pass compile configurations from Python bindings to operator implementations.