Uh oh!
There was an error while loading. Please reload this page.
refactor(cuda): adapt InfiniLM GELU and sigmoid providers - #901
Merged
voltjia merged 1 commit intoAug 7, 2026
Conversation
voltjia
merged commit Aug 7, 2026
5600d68
into
feat/add-canonical-activation-providers
6 checks passed
Uh oh!
There was an error while loading. Please reload this page.
voltjia added a commit
that referenced
this pull request
Aug 7, 2026
* feat(ops): add canonical activation providers * refactor(cuda): adapt InfiniLM GELU and sigmoid providers (#901)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeluInfinilm,GelutanhInfinilm, andSigmoidInfinilmwith thin adapters to the canonical providers introduced by feat(cuda): add canonical GELU and sigmoid providers #889.Motivation
The deprecated compatibility operators should not retain separate CUDA kernels after canonical, open-source-aligned operators exist. Sharing the providers keeps legacy callers working while removing duplicate implementation paths.
Depends on #889.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Focused pytest output
Benchmark / Performance Impact
N/A. This is provider reuse with no intended behavior or performance change.
Notes for Reviewers
GeluInfinilm(input, approximate, out)Gelu(input, approximate, out)torch.nn.functional.gelu(input, approximate='none')GelutanhInfinilm(input, out)Gelu(input, tanh, out)torch.nn.functional.gelu(..., approximate='tanh')SigmoidInfinilm(input, out)Sigmoid(input, out)torch.sigmoid(input, *, out=None)InfiniOps keeps explicit output tensors per
CONTRIBUTING.md. The legacy empty GELU approximation string is normalized to PyTorch's canonicalnonevalue before delegation.