Skip to content

Addressed "Very high" Coverity issue: dereferencing null pointer - #1369

Merged
oleksandr-pavlyk merged 2 commits into
masterfrom
fix-coverity-issue-in-dpctl-sycl-queue-interface
Aug 28, 2023
Merged

Addressed "Very high" Coverity issue: dereferencing null pointer#1369
oleksandr-pavlyk merged 2 commits into
masterfrom
fix-coverity-issue-in-dpctl-sycl-queue-interface

Conversation

@oleksandr-pavlyk

@oleksandr-pavlykoleksandr-pavlyk commented Aug 25, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Ensured that create_property_list always returns an not-null unique pointer by creating an default-constructed property_list for the fall-through.

With this change we no longer need two branches for call to sycl::queue constructor, since propList is always available.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Addressed Very high Coverity issue
60d1f26
Ensured that `create_property_list` always returns an not-null unique
pointer by creating an default-constructed property_list for the
fall-through.
With this change we no longer need to branches for call to sycl::queue
constructor, since propList is always available.
@github-actions

github-actionsBot commented Aug 25, 2023

Copy link
Copy Markdown

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1369/index.html

@coveralls

coveralls commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 85.645% (+0.009%) from 85.636% when pulling 60d1f26 on fix-coverity-issue-in-dpctl-sycl-queue-interface into 8eab04b on master.

@github-actions

github-actionsBot commented Aug 25, 2023

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_15 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlykoleksandr-pavlyk changed the title Addressed Very high Coverity issueAddressed "Very high" Coverity issueAug 25, 2023
ndgrigorian
ndgrigorian previously approved these changes Aug 26, 2023
View reviewed changes
@oleksandr-pavlykoleksandr-pavlyk changed the title Addressed "Very high" Coverity issueAddressed "Very high" Coverity issue: dereferencing null pointerAug 27, 2023
diptorupd
diptorupd reviewed Aug 28, 2023
View reviewed changes
Comment threadlibsyclinterface/source/dpctl_sycl_queue_interface.cpp Outdated
diptorupd
diptorupd reviewed Aug 28, 2023
View reviewed changes
Comment threadlibsyclinterface/source/dpctl_sycl_queue_interface.cpp
propList =
std::make_unique<property_list>(sycl::property::queue::in_order());
}
else {

@diptorupddiptorupdAug 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware SYCL runtime allows an empty property_list. The change is good.

oleksandr-pavlyk
oleksandr-pavlyk commented Aug 28, 2023
View reviewed changes
Comment threadlibsyclinterface/source/dpctl_sycl_queue_interface.cpp Outdated
@oleksandr-pavlyk
Update libsyclinterface/source/dpctl_sycl_queue_interface.cpp
dd6a014
Remove unneeded static keyword in definition of create_property_list function in anonymous namespace
@github-actions

github-actionsBot commented Aug 28, 2023

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_29 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk
oleksandr-pavlyk merged commit 718c51e into masterAug 28, 2023
@oleksandr-pavlyk
oleksandr-pavlyk deleted the fix-coverity-issue-in-dpctl-sycl-queue-interface branch August 28, 2023 19:04
@github-actions

github-actionsBot commented Aug 28, 2023

Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions

github-actionsBot commented Aug 28, 2023

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_29 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlykoleksandr-pavlyk mentioned this pull request Sep 11, 2023
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorianndgrigorianndgrigorian left review comments
+1 more reviewer
@diptorupddiptorupddiptorupd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oleksandr-pavlyk@coveralls@diptorupd@ndgrigorian