Added submit_keep_args_alive by oleksandr-pavlyk · Pull Request #1395 · IntelPython/dpctl

oleksandr-pavlyk · 2023-09-07T16:43:19Z

Added dpctl.SyclQueue._submit_keep_args_alive(args, events) that increments reference count of args object (typically a sequence of arguments an asynchronous task is operating on), ensuring that args object is not garbage collected until after events signal that tasks working on these objects complete their execution.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2023-09-15T21:11:34Z

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1395/index.html

coveralls · 2023-09-15T21:18:46Z

coverage: 85.763% (+0.06%) from 85.701% when pulling 10722d4 on async-ref-count-increment into 1d57614 on master.

github-actions · 2023-09-15T21:58:20Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_9 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-15T22:38:47Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_10 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-18T18:13:47Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_12 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-18T18:32:36Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_13 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-18T20:43:26Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_15 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-18T20:58:12Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_16 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-19T15:41:39Z

Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_14 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-22T03:23:21Z

Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_30 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-23T23:07:37Z

Array API standard conformance tests for dpctl=0.15.0rc2=py310ha25a700_17 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-25T23:32:49Z

Array API standard conformance tests for dpctl=0.15.0rc2=py310ha25a700_24 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-25T23:36:36Z

Array API standard conformance tests for dpctl=0.15.0rc2=py310ha25a700_25 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-27T16:38:29Z

Array API standard conformance tests for dpctl=0.15.0rc3=py310ha25a700_13 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@mbecker

This is an adaptation of pipelining technique shared by @mbecker in https://github.com/IntelPython/numbda_dpex/issues/147 This is built to work with async-ref-count-increment branch IntelPython/dpctl#1395 which implements asynchronous memcpy, asynchronous submit and asynchronous keep_arg_alve task submission.

github-actions · 2023-10-05T22:11:09Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_16 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

github-actions · 2023-10-05T22:58:11Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_17 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

github-actions · 2023-10-06T03:23:30Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_18 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

github-actions · 2023-10-06T17:46:40Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_19 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

github-actions · 2023-10-10T13:08:51Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_44 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

github-actions · 2023-10-14T21:52:23Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_53 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

Usage: q = dpctl.SyclQueue() ... e = q.submit(krn, args, ranges) ht_e = q._submit_keep_args_alive(args, [e]) .... ht_e.wait()

Instead delegated the task of Python object life-time management to the user via use of _submit_keep_args_alive method

The SyclQueue.submit has become synchronosing, although it still returns a SyclEvent (with exectuion_status always complete)

This is the copy operation where one can specify list of events the copy operation requires before start of its execution. DPCTLQueue_MemcpyWithEvents( __dpctl_keep DPCTLSyclQueueRef QRef, void *dst, const void *src, size_t nbytes, const DPCTLSyclEventRef *depEvents, size_t nDE ) Uses this function in tests.

Also extends `dpctl.SyclQueue.memcpy` to allow arguments to be objects that expose buffer protocol, allowing `dpctl.SyclQueue.memcpy` and `dpctl.SyclQueue.memcpy_async` to be used to copy from/to USM-allocation or host buffer.

``` In [9]: timer = dpctl.SyclTimer() In [10]: with timer(q): ...: y = dpt.linspace(1, 2, num=10**6, sycl_queue=q) ...: In [11]: timer.dt Out[11]: (0.0022024469999450957, 0.002116712) In [12]: with timer(q): ...: x = dpt.linspace(0, 1, num=10**6, sycl_queue=q) ...: In [13]: timer.dt Out[13]: (0.004531950999989931, 0.004239664000000001) ```

The object can unpack into a tuple, like before, but it prints with annotation of what each number means, and provides names getters. with timer(q): code dur = timer.dt print(dur) # outputs (host_dt=..., device_dt=...) dur.host_dt # get host-timer delta dur.device_dt # get device-timer delta hdt, ddt = dur # unpack into a tuple

oleksandr-pavlyk · 2023-10-17T20:56:38Z

I tested numba_dpex test suite with dpctl from this PR, and all tests passed.

github-actions · 2023-10-17T22:14:23Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_56 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

oleksandr-pavlyk requested a review from diptorupd September 7, 2023 16:43

oleksandr-pavlyk force-pushed the async-ref-count-increment branch 2 times, most recently from 3a92246 to 19b628eCompare September 15, 2023 20:40

oleksandr-pavlyk force-pushed the async-ref-count-increment branch from 6daca36 to 1b393d4Compare September 19, 2023 14:09

oleksandr-pavlyk force-pushed the async-ref-count-increment branch 2 times, most recently from 4c8ae59 to bb473daCompare September 22, 2023 02:07

oleksandr-pavlyk marked this pull request as ready for review September 22, 2023 22:35

oleksandr-pavlyk mentioned this pull request Sep 23, 2023
Port back fixes from async-ref-count-increment branch #1418
Merged
6 tasks

oleksandr-pavlyk force-pushed the async-ref-count-increment branch from bb473da to 7c51f2fCompare September 23, 2023 21:54

oleksandr-pavlyk force-pushed the async-ref-count-increment branch from 11b92bb to 7c51f2fCompare September 25, 2023 22:21

oleksandr-pavlyk force-pushed the async-ref-count-increment branch from 7c51f2f to 7f79887Compare September 27, 2023 15:19

oleksandr-pavlyk force-pushed the async-ref-count-increment branch from 7f79887 to e303eaaCompare October 5, 2023 20:54

oleksandr-pavlyk force-pushed the async-ref-count-increment branch from f822827 to ed67ac8Compare October 6, 2023 01:51

oleksandr-pavlyk force-pushed the async-ref-count-increment branch from ed67ac8 to 802ead7Compare October 6, 2023 16:22

oleksandr-pavlyk force-pushed the async-ref-count-increment branch from 5b3643c to cebd7f9Compare October 14, 2023 20:25

oleksandr-pavlyk added 13 commits October 17, 2023 12:13

Added SyclQueue._submit_keep_args_alive method
be5fb99
Usage: q = dpctl.SyclQueue() ... e = q.submit(krn, args, ranges) ht_e = q._submit_keep_args_alive(args, [e]) .... ht_e.wait()

Used _submit_keep_args_alive in a test
5b5363e

Do not use async_dec_ref in submit method
0a35e9c
Instead delegated the task of Python object life-time management to the user via use of _submit_keep_args_alive method

Add memcpy_async method
f30a6a2

Introduce dpctl.SyclQueue.submit_async
e7ee1d9
The SyclQueue.submit has become synchronosing, although it still returns a SyclEvent (with exectuion_status always complete)

Use pragma once in _host_task_util.hpp
b6dd4d2

Fixed possible memory leak on error
306ff96

Adds dpctl.SyclQueue.memcpy_async
6949e69
Also extends `dpctl.SyclQueue.memcpy` to allow arguments to be objects that expose buffer protocol, allowing `dpctl.SyclQueue.memcpy` and `dpctl.SyclQueue.memcpy_async` to be used to copy from/to USM-allocation or host buffer.

One of the memcpy_async calls must use events
cf9084d

Make cdef function except * to channel Python exceptions
0a73764

oleksandr-pavlyk force-pushed the async-ref-count-increment branch from cebd7f9 to 10722d4Compare October 17, 2023 20:57

oleksandr-pavlyk merged commit 26b9c92 into masterOct 24, 2023

oleksandr-pavlyk deleted the async-ref-count-increment branch October 24, 2023 00:16

oleksandr-pavlyk mentioned this pull request Jan 26, 2024
Populated changelog of new features since 0.15.0 release #1510
Merged
6 tasks

Uh oh!

Conversation

oleksandr-pavlyk commented Sep 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Sep 15, 2023

Uh oh!

coveralls commented Sep 15, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Sep 15, 2023

Uh oh!

github-actionsBot commented Sep 15, 2023

Uh oh!

github-actionsBot commented Sep 18, 2023

Uh oh!

github-actionsBot commented Sep 18, 2023

Uh oh!

github-actionsBot commented Sep 18, 2023

Uh oh!

github-actionsBot commented Sep 18, 2023

Uh oh!

github-actionsBot commented Sep 19, 2023

Uh oh!

github-actionsBot commented Sep 22, 2023

Uh oh!

github-actionsBot commented Sep 23, 2023

Uh oh!

github-actionsBot commented Sep 25, 2023

Uh oh!

github-actionsBot commented Sep 25, 2023

Uh oh!

github-actionsBot commented Sep 27, 2023

Uh oh!

github-actionsBot commented Oct 5, 2023

Uh oh!

github-actionsBot commented Oct 5, 2023

Uh oh!

github-actionsBot commented Oct 6, 2023

Uh oh!

github-actionsBot commented Oct 6, 2023

Uh oh!

github-actionsBot commented Oct 10, 2023

Uh oh!

github-actionsBot commented Oct 14, 2023

Uh oh!

oleksandr-pavlyk commented Oct 17, 2023

Uh oh!

github-actionsBot commented Oct 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

oleksandr-pavlyk commented Sep 7, 2023•
edited
Loading

coveralls commented Sep 15, 2023•
edited
Loading