Uh oh!
There was an error while loading. Please reload this page.
Implement product - #1426
Conversation
Implementation of Identity trait should call sycl::known_identity if trait sycl::has_known_identity is a true_type. Added IsMultiplies, and identity value for it, since sycl::known_identity for multiplies is only defined for real-valued types.
afb44f4 to
ca0ff64CompareArray API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_23 ran successfully. |
1 similar comment
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_23 ran successfully. |
ndgrigorian
commented
Oct 1, 2023
@oleksandr-pavlyk In testing out a The workaround that I used was a |
…icable Passing these function pointers around allows to turn atomic off altogether if desired. Use custom trait to check if reduce_over_groups can be used. This allows to work-around bug, or switch to custom code for reduction over group if desired. Such custom trait type works around issue with incorrect result returned from sycl::reduce_over_group for sycl::multiplies operator for 64-bit integral types.
Also tweaked docstring for sum.
Uh oh!
There was an error while loading. Please reload this page.
7fa4fe6 to
1d9b7ceCompareUh oh!
There was an error while loading. Please reload this page.
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1426/index.html |
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_24 ran successfully. |
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_25 ran successfully. |
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_26 ran successfully. |
Small tweaks to sum, min, and max docstrings
ndgrigorian
left a comment
There was a problem hiding this comment.
@oleksandr-pavlyk
I pushed a small change with a tweak to some docstrings.
I think this is good to go in.
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_27 ran successfully. |
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
This is PR builds on top of work of #1399 and implements
_prod_over_axisand the satellite associated type query function.The product runs into problems for complex types, and does not give the expected output for integral types, so this is a work-in-progress.