Skip to content

Elementwise functions cbrt, exp2, copysign, and rsqrt - #1443

Merged
ndgrigorian merged 5 commits into
masterfrom
new-spec-elementwise-funcs
Oct 17, 2023
Merged

Elementwise functions cbrt, exp2, copysign, and rsqrt#1443
ndgrigorian merged 5 commits into
masterfrom
new-spec-elementwise-funcs

Conversation

@ndgrigorian

@ndgrigorianndgrigorian commented Oct 16, 2023

Copy link
Copy Markdown
Collaborator

This pull request implements dpctl.tensor.cbrt, dpctl.tensor.exp2, and dpctl.tensor.copysign, new elementwise functions coming to the array API specification.

It also adds dpctl.tensor.rsqrt for computing the reciprocal square root of a floating-point arrays with greater accuracy.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions

Copy link
Copy Markdown

@ndgrigorian
ndgrigorianforce-pushed the new-spec-elementwise-funcs branch from 5ae12c4 to c8f3e03CompareOctober 16, 2023 01:14
@ndgrigorian
ndgrigorianforce-pushed the new-spec-elementwise-funcs branch from c8f3e03 to 64eb98cCompareOctober 16, 2023 01:17
@github-actions

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_43 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@coveralls

coveralls commented Oct 16, 2023

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 85.701% (+0.009%) from 85.692% when pulling 3e08194 on new-spec-elementwise-funcs into af04d34 on master.

@github-actions

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_43 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

1 similar comment
@github-actions

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_43 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@ndgrigorianndgrigorian changed the title Elementwise functions cbrt, exp2, and copysignElementwise functions cbrt, exp2, copysign, and rsqrtOct 16, 2023
Now test more type combinations/output types
@github-actions

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_45 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@github-actions

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_44 ran successfully.
Passed: 934
Failed: 66
Skipped: 119

@oleksandr-pavlykoleksandr-pavlyk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @ndgrigorian !

@oleksandr-pavlykoleksandr-pavlyk mentioned this pull request Oct 17, 2023
6 tasks
@ndgrigorian
ndgrigorian merged commit 2d2f235 into masterOct 17, 2023
@ndgrigorian
ndgrigorian deleted the new-spec-elementwise-funcs branch October 25, 2023 20:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian@coveralls@oleksandr-pavlyk