Skip to content

Fixed dpctl.tensor.result_type function for scalars - #1473

Merged
oleksandr-pavlyk merged 4 commits into
masterfrom
fix_result_type
Jan 18, 2024
Merged

Fixed dpctl.tensor.result_type function for scalars#1473
oleksandr-pavlyk merged 4 commits into
masterfrom
fix_result_type

Conversation

@npolina4

@npolina4npolina4 commented Nov 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Added support for weak scalars data type.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@coveralls

coveralls commented Nov 13, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 90.187% (+0.2%) from 89.993%
when pulling 01e9d9c on fix_result_type
into 700079f on master.

@github-actions

github-actionsBot commented Nov 13, 2023

Copy link
Copy Markdown

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1473/index.html

@github-actions

github-actionsBot commented Nov 13, 2023

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev2=py310ha25a700_2 ran successfully.
Passed: 1022
Failed: 51
Skipped: 60

@github-actions

github-actionsBot commented Nov 14, 2023

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev2=py310ha25a700_3 ran successfully.
Passed: 1022
Failed: 51
Skipped: 60

oleksandr-pavlyk
oleksandr-pavlyk reviewed Dec 18, 2023
View reviewed changes
Comment threaddpctl/tensor/_manipulation_functions.py Outdated
@oleksandr-pavlyk
tensor.result_type now also handles Python scalars
8a20e6a
It handles scalars consistently with the way elementwise
operations do, following NEP-0050.
Some definitions were migrated from _elementwise_common
to _type_utils.
@oleksandr-pavlyk
Test result_type with Python scalars
f53f816
@github-actions

github-actionsBot commented Jan 17, 2024

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_3 ran successfully.
Passed: 896
Failed: 13
Skipped: 86

@github-actions

github-actionsBot commented Jan 17, 2024

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_4 ran successfully.
Passed: 894
Failed: 15
Skipped: 86

@github-actions

github-actionsBot commented Jan 17, 2024

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_5 ran successfully.
Passed: 890
Failed: 19
Skipped: 86

@github-actions

github-actionsBot commented Jan 17, 2024

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_5 ran successfully.
Passed: 892
Failed: 17
Skipped: 86

@github-actions

github-actionsBot commented Jan 17, 2024

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_5 ran successfully.
Passed: 893
Failed: 16
Skipped: 86

ndgrigorian
ndgrigorian approved these changes Jan 17, 2024
View reviewed changes

@ndgrigorianndgrigorian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior for Numpy scalars seems worth noting
(the device does not support fp64)

In [9]: dpt.result_type(dpt.empty(0, dtype="f4"), np.float64(2))
Out[9]: dtype('float32')

But we usually treat them as Python scalars anyway, so I don't see a reason to change anything here.

Overall LGTM!

@oleksandr-pavlyk
oleksandr-pavlyk merged commit fbe0081 into masterJan 18, 2024
@oleksandr-pavlyk
oleksandr-pavlyk deleted the fix_result_type branch January 18, 2024 04:27
@oleksandr-pavlykoleksandr-pavlyk mentioned this pull request Jan 26, 2024
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorianndgrigorianndgrigorian approved these changes
@oleksandr-pavlykoleksandr-pavlykAwaiting requested review from oleksandr-pavlyk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@npolina4@coveralls@oleksandr-pavlyk@ndgrigorian