Skip to content

Fix array API inspection behavior with device keyword - #1979

Merged
ndgrigorian merged 4 commits into
masterfrom
fix-device-keyword-in-array-api-inspection
Jan 24, 2025
Merged

Fix array API inspection behavior with device keyword#1979
ndgrigorian merged 4 commits into
masterfrom
fix-device-keyword-in-array-api-inspection

Conversation

@ndgrigorian

@ndgrigorianndgrigorian commented Jan 23, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR proposes changing the handling of the device keyword in the array API inspection utilities to:

  • raise a more helpful exception for unexpected inputs
  • work correctly with filter strings and SyclQueues

Also fixes the dtypes utility returning complex128 in its output when the provided device does not support double precision types.

Resolves#1978 , resolves#1977

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
Array API inspection utilities interfacing with devices fixed
348dd3d
* Fixes a bug where `"complex128"` was present in the list of dtypes on devices without fp64 support
* Fixes functionality of device keyword for SyclQueue and strings
* Improves error message when device keyword cannot be used to construct a SyclDevice instance
* Tweaks docstring for device keywords in inspection utilities
@github-actions

github-actionsBot commented Jan 24, 2025•
edited
Loading

Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions

github-actionsBot commented Jan 24, 2025

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_493 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@github-actions

github-actionsBot commented Jan 24, 2025

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_494 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls

coveralls commented Jan 24, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 88.24% (+0.06%) from 88.18%
when pulling 06f266c on fix-device-keyword-in-array-api-inspection
into c5cbb08 on master.

@ndgrigorian
ndgrigorian marked this pull request as ready for review January 24, 2025 05:24
@ndgrigorian

ndgrigorian commented Jan 24, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@antonwolfy
This is now ready for your review

@github-actions

github-actionsBot commented Jan 24, 2025

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_496 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

antonwolfy
antonwolfy approved these changes Jan 24, 2025
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with dpnp changes added in dpnp-2275 and it works as expected now.
Thank you @ndgrigorian for a quick fix. LGTM!

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Jan 24, 2025
View reviewed changes
Comment threaddpctl/tensor/_array_api.py
@ndgrigorian
ndgrigorian merged commit 7bc3d80 into masterJan 24, 2025
@ndgrigorian
ndgrigorian deleted the fix-device-keyword-in-array-api-inspection branch January 24, 2025 15:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
+1 more reviewer
@oleksandr-pavlykoleksandr-pavlykoleksandr-pavlyk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

__array_namespace_info__.dtypes raises AttributeError for device passed as a string __array_namespace_info__ returns complex128 dtype when no fp64

4 participants

@ndgrigorian@coveralls@oleksandr-pavlyk@antonwolfy