Uh oh!
There was an error while loading. Please reload this page.
Add support for raw_kernel_arg extension - #2038
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ndgrigorian
commented
Apr 14, 2025
@sommerlukas |
1ea6b9c to
296e236CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Switch approach to not introduce an intermediate struct, but have the opaque pointer directly point to std::vector instead.
sommerlukas
commented
Apr 22, 2025
Thanks for the feedback @ndgrigorian@AlexanderKalistratov! After taking a look at how the opaque pointers for other |
ba642e9 to
a0b4c75Compare@ndgrigorian@AlexanderKalistratov Friendly ping for reviews. CI is looking quite good now, I can unfortunately not see the logs for the single failing Jenkins job. |
AlexanderKalistratov
left a comment
There was a problem hiding this comment.
@sommerlukas PR looks great for me, thank you!
I'm not code owner, so we need to wait @ndgrigorian review as well
ndgrigorian
commented
Apr 30, 2025
Sorry, forgot to put my final review on this. Jenkins job is unrelated. I'll give it a last look over but I think it's ready to go in. |
Add support for the DPC++ SYCL extension
raw_kernel_argthat allows to pass a binary blob as kernel arguments.This is for example useful if the kernel uses a
structas kernel parameter, but is loaded from SPIR-V and the argument type is unknown forset_arg.The implementation follows #1984.