Skip to content

Add missing device info queries - #2324

Merged
ndgrigorian merged 14 commits into
masterfrom
add-missing-device-info-queries
Aug 6, 2026
Merged

Add missing device info queries#2324
ndgrigorian merged 14 commits into
masterfrom
add-missing-device-info-queries

Conversation

@ndgrigorian

@ndgrigorianndgrigorian commented Jun 12, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR adds the missing SYCL 2020 spec (i.e., non-extension) device info queries to dpctl.SyclDevice

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions

github-actionsBot commented Jun 12, 2026•
edited
Loading

Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls

coveralls commented Jun 12, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 74.054% (-0.5%) from 74.579% — add-missing-device-info-queries into master

antonwolfy
antonwolfy reviewed Jul 8, 2026
View reviewed changes
Comment threaddpctl/__init__.py
Comment threaddpctl/_sycl_device.pyx Outdated
Comment threadlibsyclinterface/tests/test_sycl_device_interface.cpp Outdated
Comment threadlibsyclinterface/include/syclinterface/dpctl_sycl_device_interface.h Outdated
Comment threadlibsyclinterface/tests/test_sycl_device_interface.cpp
@ndgrigorian
ndgrigorianforce-pushed the add-missing-device-info-queries branch from 368514e to 38b62bfCompareAugust 3, 2026 22:33
antonwolfy
antonwolfy reviewed Aug 4, 2026
View reviewed changes
Comment threadlibsyclinterface/include/syclinterface/dpctl_sycl_device_interface.h Outdated
Comment threadlibsyclinterface/source/dpctl_sycl_device_interface.cpp
Comment threadlibsyclinterface/source/dpctl_sycl_device_interface.cpp Outdated
Comment threadlibsyclinterface/tests/test_sycl_device_interface.cpp Outdated
Comment threaddpctl/tests/_device_attributes_checks.py
Comment threaddpctl/_sycl_device.pyx
Comment threaddpctl/_sycl_device.pyx
Comment threaddpctl/_sycl_device.pyx Outdated
@ndgrigorian
ndgrigorianforce-pushed the add-missing-device-info-queries branch from 17ce890 to 03911c8CompareAugust 4, 2026 18:18
@ndgrigorian
ndgrigorianforce-pushed the add-missing-device-info-queries branch from 03911c8 to 75030b5CompareAugust 4, 2026 18:27
antonwolfy
antonwolfy previously approved these changes Aug 5, 2026
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with only small question below

Comment threadlibsyclinterface/source/dpctl_sycl_device_interface.cpp Outdated
antonwolfy
antonwolfy reviewed Aug 5, 2026
View reviewed changes
Comment threadlibsyclinterface/include/syclinterface/dpctl_sycl_enum_types.h
antonwolfy
antonwolfy approved these changes Aug 6, 2026
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian, no more comments from me

@ndgrigorian
ndgrigorian merged commit be19858 into masterAug 6, 2026
88 of 101 checks passed
@ndgrigorian
ndgrigorian deleted the add-missing-device-info-queries branch August 6, 2026 12:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
@vlad-perevezentsevvlad-perevezentsevAwaiting requested review from vlad-perevezentsevvlad-perevezentsev is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian@coveralls@antonwolfy