Skip to content

Leverage dpctl.tensor.iinfo() and dpctl.tensor.finfo() implementation. - #1582

Merged
antonwolfy merged 4 commits into
masterfrom
iinfo_finfo
Oct 11, 2023
Merged

Leverage dpctl.tensor.iinfo() and dpctl.tensor.finfo() implementation.#1582
antonwolfy merged 4 commits into
masterfrom
iinfo_finfo

Conversation

@npolina4

@npolina4npolina4 commented Oct 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Leverage dpctl.tensor.iinfo() and dpctl.tensor.finfo() implementation.
The usage of the numpy.iinfo and numpy.finfo functions has been changed to dpnp.iinfo and dpnp.finfo.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions

github-actionsBot commented Oct 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Oct 10, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface_types.py Outdated
Comment threaddpnp/dpnp_iface_types.py
Comment threaddpnp/dpnp_iface_types.py Outdated
antonwolfy
antonwolfy reviewed Oct 10, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface_types.py
@npolina4npolina4 mentioned this pull request Oct 10, 2023
Closed
5 tasks
antonwolfy
antonwolfy approved these changes Oct 11, 2023
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@antonwolfy
antonwolfy merged commit 0fe9a00 into masterOct 11, 2023
@antonwolfy
antonwolfy deleted the iinfo_finfo branch October 11, 2023 12:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
@vlad-perevezentsevvlad-perevezentsevAwaiting requested review from vlad-perevezentsevvlad-perevezentsev is a code owner
@vtavanavtavanaAwaiting requested review from vtavana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@npolina4@antonwolfy