Skip to content

in place divide and floor_divide - #1587

Merged
vtavana merged 4 commits into
masterfrom
divide_in_place
Nov 13, 2023
Merged

in place divide and floor_divide#1587
vtavana merged 4 commits into
masterfrom
divide_in_place

Conversation

@vtavana

@vtavanavtavana commented Oct 11, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Dedicated kernels are implemented in dpctl for in-place division and floor division #1431

In this PR, this feature is added for dpnp.divide and dpnp.floor_divide.
New tests are written for them.

UPDATE:
With recent updates in dpctl (#1463), the usage of in-place operator are automatically incorporated in dpnp. This PR now only updates the relevant tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Oct 11, 2023
@github-actions

github-actionsBot commented Oct 11, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana
vtavana marked this pull request as ready for review October 11, 2023 04:48
antonwolfy
antonwolfy reviewed Oct 11, 2023
View reviewed changes
Comment threadtests/test_mathematical.py Outdated
Comment threadtests/test_mathematical.py
Comment threadtests/test_mathematical.py Outdated
@vtavana
vtavanaforce-pushed the divide_in_place branch 4 times, most recently from 8b1656e to 1a58867CompareOctober 12, 2023 20:15
antonwolfy
antonwolfy approved these changes Oct 12, 2023
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vtavana

Comment threadtests/test_mathematical.py Outdated
@vtavana
vtavanaforce-pushed the divide_in_place branch 2 times, most recently from 106537e to 88c113dCompareNovember 8, 2023 04:44
@vtavana
vtavana merged commit c31557c into masterNov 13, 2023
@vtavana
vtavana deleted the divide_in_place branch November 13, 2023 20:18
@antonwolfyantonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorianndgrigorianndgrigorian left review comments
@antonwolfyantonwolfyantonwolfy approved these changes

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana@ndgrigorian@antonwolfy