Skip to content

implement dpnp.max and dpnp.min using dpctl.tensor functions - #1602

Merged
vtavana merged 7 commits into
masterfrom
max_min
Nov 8, 2023
Merged

implement dpnp.max and dpnp.min using dpctl.tensor functions#1602
vtavana merged 7 commits into
masterfrom
max_min

Conversation

@vtavana

@vtavanavtavana commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

In this PR, dpnp.max and dpnp.min are implemented using their dpctl.tensor counterparts.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Oct 18, 2023
@github-actions

github-actionsBot commented Oct 18, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana
vtavana marked this pull request as ready for review October 18, 2023 18:24
@vtavanavtavana changed the title implement dpnp.max and dpnp.max using dpctl.tensor functionsimplement dpnp.max and dpnp.min using dpctl.tensor functionsOct 18, 2023
antonwolfy
antonwolfy reviewed Oct 25, 2023
View reviewed changes
Comment threaddpnp/dpnp_array.py
Comment threadtests/skipped_tests.tbl
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threadtests/test_statistics.py Outdated
antonwolfy
antonwolfy reviewed Oct 26, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threadtests/test_amin_amax.py
antonwolfy
antonwolfy reviewed Oct 26, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
antonwolfy
antonwolfy reviewed Oct 30, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface_statistics.py
Comment threaddpnp/dpnp_iface_statistics.py
antonwolfy
antonwolfy approved these changes Oct 30, 2023
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you @vtavana

Comment threadtests/test_statistics.py Outdated
@vtavana
vtavana merged commit 79cb518 into masterNov 8, 2023
@vtavana
vtavana deleted the max_min branch November 8, 2023 04:38
@antonwolfyantonwolfy mentioned this pull request Jan 9, 2024
Merged
@vtavanavtavana mentioned this pull request Jan 17, 2024
Closed
6 tasks
@vlad-perevezentsevvlad-perevezentsev mentioned this pull request Jun 26, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
@vlad-perevezentsevvlad-perevezentsevAwaiting requested review from vlad-perevezentsevvlad-perevezentsev is a code owner
@npolina4npolina4Awaiting requested review from npolina4

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana@antonwolfy