Skip to content

Update dpnp.linalg.svd() function - #1604

Merged
vlad-perevezentsev merged 78 commits into
masterfrom
impl_svd
Feb 2, 2024
Merged

Update dpnp.linalg.svd() function#1604
vlad-perevezentsev merged 78 commits into
masterfrom
impl_svd

Conversation

@vlad-perevezentsev

@vlad-perevezentsevvlad-perevezentsev commented Oct 19, 2023

Copy link
Copy Markdown
Contributor

This PR update dpnp.linalg.svd() function to calculate the Singular Value Decomposition using oneapi::mkl::lapack::gesvd
The implementation is written as a pybind11 extension above required LAPACK functions.
The changes are related to support of all types and support of function arguments as full_matrices and compute_uv

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsevvlad-perevezentsev self-assigned this Oct 19, 2023
@github-actions

github-actionsBot commented Oct 19, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Jan 23, 2024
View reviewed changes
Comment threaddpnp/backend/extensions/lapack/gesvd.cpp
Comment threaddpnp/backend/extensions/lapack/gesvd.cpp
Comment threaddpnp/linalg/dpnp_iface_linalg.py Outdated
Comment threaddpnp/linalg/dpnp_utils_linalg.py Outdated
Comment threaddpnp/linalg/dpnp_utils_linalg.py Outdated
Comment threaddpnp/linalg/dpnp_utils_linalg.py
vlad-perevezentsev
vlad-perevezentsev commented Jan 23, 2024
View reviewed changes
Comment threaddpnp/linalg/dpnp_utils_linalg.py

if compute_uv:
out_u = dpnp.array(u_matrices, order="F")
out_vt = dpnp.array(vt_matrices, order="F")

@vlad-perevezentsevvlad-perevezentsevJan 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to return C-contiguous array to match the output of numpy.linalg.svd

vlad-perevezentsev
vlad-perevezentsev commented Jan 23, 2024
View reviewed changes
Comment threaddpnp/linalg/dpnp_utils_linalg.py
ht_lapack_ev.wait()
a_ht_copy_ev.wait()

if compute_uv:

@vlad-perevezentsevvlad-perevezentsevJan 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to return C-contiguous array to match the output of numpy.linalg.svd

antonwolfy
antonwolfy approved these changes Jan 24, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev

@vlad-perevezentsev
vlad-perevezentsev merged commit c7770fd into masterFeb 2, 2024
@vlad-perevezentsev
vlad-perevezentsev deleted the impl_svd branch February 2, 2024 13:21
github-actionsBot added a commit to antonwolfy/dpnp that referenced this pull request Feb 2, 2024
@github-actions
Update dpnp.linalg.svd() function (IntelPython#1604)
7017ce0
* Draft commit of dpnp.linalg.svd impl
* Pass empty arrays if compute_uv=False
* Add logic for the input array n < m
* Add a new cupy test_decomposition
* Rename gesvd input parameters
* Correspondence of passed parameters to gesvd signature
* Correct initialization of result variables in dpnp_svd
* Update test_decomposition
* Add implementation of _dpnp_svd_batch
* Add test_decomposition to the scope of public CI
* Improve error handling for mkl_lapack::gesvd function
* Declate detail variable
* Use a_usm_type and a_sycl_queue variables
* Add additional checks for gesvd function
* Remove old dpnp_svd backend
* Refresh test_svd in test_linalg
* Add detailed comments for gesvd arguments
* gesvd returns pair of events and uses dpctl.utils.keep_args_alive
* Keep a lexicographical order
* Update docstrings for svd
* Add test_svd to test_usm_type
* Add a new impl to get s_type
* Add a description for _stacked_identity
* Simplify dpnp_svd_batch
* Update tests for dpnp.linalg.svd
* Add hermitian argument support
* Add test_svd_hermitian
* Update svd docstrings
* Tune tolerance
* Update test_svd_errors
* Update _common_type and _common_inexact_type
* Remove passing n and m parameteres to _gesvd
* Simplify results return logic for dpnp_svd_batch
* Update condition and random files in cupy/testing to use fix_random and repeat decorators
* Rename cupy/testing/condition.py to .../_condition.py
* Use self._tol in TestSvd
* Update gesvd error handler
* dpnp_svd works with F contiguous arrays
* Add additional checks for output arrays
* Impl parallel calculation in dpnp_svd_batch
* Skip using @_condition.repeat in cupy tests
* Add additional checks for output arrays
* Update docstrings for svd
* Use dpctl.SyclEvent.wait_for in dpnp_svd_batch
* Add TODO : matching the order of returned arrays
* Skip cupy tests on windows
* Rename condition to _condition
* Set setUpClass to skip cupy tests on cpu c7770fd
@vlad-perevezentsevvlad-perevezentsev mentioned this pull request Feb 7, 2024
Merged
6 tasks
@antonwolfyantonwolfy mentioned this pull request Feb 10, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
@npolina4npolina4Awaiting requested review from npolina4
@vtavanavtavanaAwaiting requested review from vtavana

Assignees

@vlad-perevezentsevvlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlad-perevezentsev@antonwolfy