Skip to content

Update dpnp.indices function - #1622

Merged
antonwolfy merged 14 commits into
masterfrom
implement_indices
Jan 16, 2024
Merged

Update dpnp.indices function#1622
antonwolfy merged 14 commits into
masterfrom
implement_indices

Conversation

@npolina4

@npolina4npolina4 commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

Added all dimensions, sparse, and dtype support. Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions

github-actionsBot commented Nov 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

vtavana
vtavana reviewed Nov 8, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface_indexing.py
Comment threaddpnp/dpnp_iface_indexing.py Outdated
Comment threaddpnp/dpnp_iface_indexing.py Outdated
Comment threaddpnp/dpnp_iface_indexing.py Outdated
Comment threaddpnp/dpnp_iface_indexing.py Outdated
Comment threadtests/third_party/cupy/indexing_tests/test_generate.py
antonwolfy
antonwolfy reviewed Nov 20, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface_indexing.py
Comment threaddpnp/dpnp_iface_indexing.py Outdated
Comment threadtests/test_sycl_queue.py Outdated
antonwolfy
antonwolfy reviewed Jan 10, 2024
View reviewed changes
Comment threaddpnp/dpnp_iface_indexing.py
Comment threaddpnp/dpnp_iface_indexing.py
Comment threaddpnp/dpnp_iface_indexing.py
Comment threadtests/test_sycl_queue.py Outdated
antonwolfy
antonwolfy approved these changes Jan 12, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4 LGTM!

@npolina4
Implement dpnp.mgrid and dpnp.ogrid function (#1633)
b86e653
* Implement dpnp.mgrid and dpnp.ogrid function
* address comments
* address comments
* Skip dtype check for Iris Xe
* Update test_ranges.py
* Added description of all parameters
@npolina4
Merge branch 'master' into implement_indices
e265aba
@antonwolfy
antonwolfy merged commit c4b3b2e into masterJan 16, 2024
@antonwolfy
antonwolfy deleted the implement_indices branch January 16, 2024 11:01
github-actionsBot added a commit to antonwolfy/dpnp that referenced this pull request Jan 16, 2024
@github-actions@antonwolfy
Update dpnp.indices function (IntelPython#1622)
de45248
* Update dpnp.indices function
* Clean up dpnp_indices
* address comments
* address comments
* cancel changes for test_indices_list3
* Added description of all parameters
* Implement dpnp.mgrid and dpnp.ogrid function (IntelPython#1633)
* Implement dpnp.mgrid and dpnp.ogrid function
* address comments
* address comments
* Skip dtype check for Iris Xe
* Update test_ranges.py
* Added description of all parameters
* Resolve pre-commit issue
---------
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton Volkov <antonwolfy@gmail.com> c4b3b2e
@antonwolfyantonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
+1 more reviewer
@vtavanavtavanavtavana left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@npolina4@antonwolfy@vtavana