Skip to content

implement dpnp.cbrt, dpnp.exp2, dpnp.copysign, dpnp.rsqrt - #1624

Merged
vtavana merged 6 commits into
masterfrom
cbrt_exp2_rsqrt_copysign
Nov 24, 2023
Merged

implement dpnp.cbrt, dpnp.exp2, dpnp.copysign, dpnp.rsqrt#1624
vtavana merged 6 commits into
masterfrom
cbrt_exp2_rsqrt_copysign

Conversation

@vtavana

@vtavanavtavana commented Nov 14, 2023

Copy link
Copy Markdown
Contributor

The PR changes the implementation of dpnp.cbrt, dpnp.exp2, dpnp.rsqrt, and dpnp.copysign.
dpnp.cbrt and dpnp.exp2 now invoke oneapi::mkl::vm implementation from pybind11 extension of OneMKL VM if possible or use dpctl.tensor implementation if not.
dpnp.rsqrt and dpnp.copysign use dpctl.tensor implementation.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Nov 14, 2023
@github-actions

github-actionsBot commented Nov 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana
vtavana marked this pull request as ready for review November 14, 2023 18:00
npolina4
npolina4 reviewed Nov 14, 2023
View reviewed changes
Comment threaddpnp/dpnp_algo/dpnp_elementwise_common.py Outdated
Comment threaddpnp/dpnp_iface_trigonometric.py Outdated
Comment threaddpnp/dpnp_iface_mathematical.py
antonwolfy
antonwolfy reviewed Nov 22, 2023
View reviewed changes
Comment threaddpnp/dpnp_algo/dpnp_elementwise_common.py Outdated
Comment threaddpnp/dpnp_iface_mathematical.py
Comment threaddpnp/dpnp_iface_trigonometric.py
Comment threaddpnp/dpnp_iface_trigonometric.py
Comment threaddpnp/dpnp_iface_trigonometric.py
Comment threadtests/test_sycl_queue.py Outdated
Comment threadtests/skipped_tests_gpu_no_fp64.tbl
Comment threadtests/third_party/cupy/math_tests/test_misc.py
antonwolfy
antonwolfy approved these changes Nov 23, 2023
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have more comments, LGTM! Thank you @vtavana

@vtavana
vtavana merged commit 780d686 into masterNov 24, 2023
@vtavana
vtavana deleted the cbrt_exp2_rsqrt_copysign branch November 24, 2023 02:45
@antonwolfyantonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
+1 more reviewer
@npolina4npolina4npolina4 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana@npolina4@antonwolfy