Skip to content

impelment dpnp.std, dpnp.var and dpnp.nanvar - #1635

Merged
antonwolfy merged 15 commits into
masterfrom
std_var
Dec 16, 2023
Merged

impelment dpnp.std, dpnp.var and dpnp.nanvar#1635
antonwolfy merged 15 commits into
masterfrom
std_var

Conversation

@vtavana

@vtavanavtavana commented Dec 4, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

In this PR,

  1. dpnp.std and dpnp.var are implemented using their dpctl counterparts.
  2. dpnp.nanvar is implemented using existing functions in dpnp.
  3. support of out keyword is added for dpnp.sum.
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Dec 4, 2023
@github-actions

github-actionsBot commented Dec 5, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana
vtavana marked this pull request as ready for review December 5, 2023 23:47
@vtavanavtavana changed the title impelment dpnp.var and dpnp.stdimpelment dpnp.std, dpnp.var and dpnp.nanvarDec 5, 2023
antonwolfy
antonwolfy reviewed Dec 8, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface.py Outdated
Comment threaddpnp/dpnp_iface.py Outdated
Comment threaddpnp/dpnp_iface.py Outdated
Comment threaddpnp/dpnp_iface.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threadtests/skipped_tests.tbl
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threadtests/third_party/cupy/statistics_tests/test_meanvar.py Outdated
antonwolfy
antonwolfy reviewed Dec 13, 2023
View reviewed changes
Comment threadtests/third_party/cupy/math_tests/test_sumprod.py
Comment threadtests/third_party/cupy/statistics_tests/test_meanvar.py Outdated
Comment threadtests/third_party/cupy/statistics_tests/test_meanvar.py Outdated
Comment threadtests/third_party/cupy/statistics_tests/test_meanvar.py Outdated
Comment threadtests/third_party/cupy/statistics_tests/test_meanvar.py
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py Outdated
antonwolfy
antonwolfy reviewed Dec 14, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface_nanfunctions.py Outdated
Comment threaddpnp/dpnp_iface_nanfunctions.py Outdated
Comment threaddpnp/dpnp_iface_nanfunctions.py Outdated
Comment threaddpnp/dpnp_iface_nanfunctions.py Outdated
Comment threadtests/third_party/cupy/statistics_tests/test_meanvar.py
Comment threadtests/conftest.py Outdated
Comment threadtests/test_statistics.py
Comment threadtests/conftest.py Outdated
Comment threadtests/third_party/cupy/statistics_tests/test_meanvar.py Outdated
Comment threadtests/third_party/cupy/statistics_tests/test_meanvar.py Outdated
antonwolfy
antonwolfy reviewed Dec 15, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface.py
antonwolfy
antonwolfy approved these changes Dec 15, 2023
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana ! Great job!

@antonwolfy
antonwolfy merged commit 996cf54 into masterDec 16, 2023
@antonwolfy
antonwolfy deleted the std_var branch December 16, 2023 11:24
github-actionsBot added a commit that referenced this pull request Dec 16, 2023
@github-actions
impelment dpnp.std, dpnp.var and dpnp.nanvar (#1635)
89f7f5d
* impelment dpnp.var and dpnp.std
* implement dpnp.nanvar
* support out keyword for dpnp.sum
* add more tests
* use replace_nan func for nanprod
* address comments
* update test_sum_empty_axis
* address new comments
* minor update
* address remarks
* remove uncalled raise 996cf54
@antonwolfyantonwolfy mentioned this pull request Jan 9, 2024
Merged
@vlad-perevezentsevvlad-perevezentsev mentioned this pull request Jun 26, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
@npolina4npolina4Awaiting requested review from npolina4

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana@antonwolfy