Skip to content

implement dpnp.nanargmax, dpnp.nanargmin, dpnp.nanmax, and dpnp.nanmin - #1646

Merged
vtavana merged 3 commits into
masterfrom
nanargmax_nanargmin
Dec 20, 2023
Merged

implement dpnp.nanargmax, dpnp.nanargmin, dpnp.nanmax, and dpnp.nanmin#1646
vtavana merged 3 commits into
masterfrom
nanargmax_nanargmin

Conversation

@vtavana

@vtavanavtavana commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

In this PR, dpnp.nanargmax, dpnp.nanargmin, dpnp.nanmax, and dpnp.nanmin are implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Dec 18, 2023
@github-actions

github-actionsBot commented Dec 18, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana
vtavana marked this pull request as ready for review December 18, 2023 20:27
antonwolfy
antonwolfy reviewed Dec 19, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface_nanfunctions.py Outdated
Comment threaddpnp/dpnp_iface_nanfunctions.py Outdated
Comment threaddpnp/dpnp_iface_nanfunctions.py Outdated
Comment threaddpnp/dpnp_iface_nanfunctions.py
Comment threaddpnp/dpnp_iface_nanfunctions.py
Comment threadtests/test_statistics.py Outdated
Comment threadtests/third_party/cupy/sorting_tests/test_search.py
Comment threadtests/third_party/cupy/sorting_tests/test_search.py
Comment threadtests/third_party/cupy/sorting_tests/test_search.py Outdated
Comment threadtests/third_party/cupy/statistics_tests/test_order.py Outdated
@vtavanavtavana changed the title implement nanargmax, nanargmin, nanmax, and nanminimplement dpnp.nanargmax, dpnp.nanargmin, dpnp.nanmax, and dpnp.nanminDec 20, 2023
antonwolfy
antonwolfy approved these changes Dec 20, 2023
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana , LGTM!

@vtavana
vtavana merged commit 680d903 into masterDec 20, 2023
@vtavana
vtavana deleted the nanargmax_nanargmin branch December 20, 2023 17:14
github-actionsBot added a commit that referenced this pull request Dec 20, 2023
@github-actions
implement dpnp.nanargmax, dpnp.nanargmin, dpnp.nanmax, and `dpn…
005e070
…p.nanmin` (#1646)
* implement nanargmax, nanargmin, nanmax, nanmin
* address comments
* suppress overflow warning 680d903
@antonwolfyantonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana@antonwolfy