Skip to content

implement dpnp.logsumexp and dpnp.reduce_hypot - #1648

Merged
vtavana merged 4 commits into
masterfrom
logsumexp_reducehypot
Dec 22, 2023
Merged

implement dpnp.logsumexp and dpnp.reduce_hypot#1648
vtavana merged 4 commits into
masterfrom
logsumexp_reducehypot

Conversation

@vtavana

@vtavanavtavana commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

In this PR, dpnp.logsumexp and dpnp.reduce_hypot are implemented using their dpctl counterpart.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Dec 20, 2023
@github-actions

github-actionsBot commented Dec 20, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana
vtavana marked this pull request as ready for review December 20, 2023 20:06
antonwolfy
antonwolfy reviewed Dec 21, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface_trigonometric.py Outdated
Comment threaddpnp/dpnp_iface_trigonometric.py Outdated
Comment threaddpnp/dpnp_iface_trigonometric.py Outdated
Comment threaddpnp/dpnp_iface_trigonometric.py Outdated
Comment threadtests/helper.py Outdated
Comment threaddpnp/dpnp_iface_trigonometric.py
Comment threaddpnp/dpnp_iface_trigonometric.py
antonwolfy
antonwolfy reviewed Dec 21, 2023
View reviewed changes
Comment threaddpnp/dpnp_iface_trigonometric.py
antonwolfy
antonwolfy approved these changes Dec 22, 2023
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana ! No more comments from me.

@vtavana
vtavana merged commit 20513fb into masterDec 22, 2023
@vtavana
vtavana deleted the logsumexp_reducehypot branch December 22, 2023 18:55
github-actionsBot added a commit to antonwolfy/dpnp that referenced this pull request Jan 8, 2024
@github-actions
implementdpnp.logsumexpanddpnp.reduce_hypot(IntelPython#1648)
422f86f
* implement logsumexp and reduce_hypot
* fix pre-commit
* address comments 20513fb
@antonwolfyantonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana@antonwolfy