Skip to content

implement dpnp.reciprocal and dpnp.angle - #1650

Merged
antonwolfy merged 10 commits into
masterfrom
reciprocal_angle
Jan 20, 2024
Merged

implement dpnp.reciprocal and dpnp.angle#1650
antonwolfy merged 10 commits into
masterfrom
reciprocal_angle

Conversation

@vtavana

@vtavanavtavana commented Jan 5, 2024

Copy link
Copy Markdown
Contributor

In this PR, dpnp.angle and dpnp.reciprocal are implemented using their dpctl counterparts.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Jan 5, 2024
@github-actions

github-actionsBot commented Jan 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana
vtavana marked this pull request as ready for review January 6, 2024 03:13
antonwolfy
antonwolfy reviewed Jan 9, 2024
View reviewed changes
Comment threaddpnp/dpnp_iface_mathematical.py
Comment threaddpnp/dpnp_iface_mathematical.py Outdated
Comment threaddpnp/dpnp_iface_trigonometric.py
Comment threadtests/third_party/cupy/math_tests/test_arithmetic.py
Comment threadtests/third_party/cupy/math_tests/test_arithmetic.py
vtavana
vtavana commented Jan 9, 2024
View reviewed changes
Comment threaddpnp/dpnp_algo/dpnp_elementwise_common.py Outdated
antonwolfy
antonwolfy reviewed Jan 9, 2024
View reviewed changes
Comment threaddpnp/dpnp_iface_trigonometric.py Outdated
Comment threaddpnp/dpnp_iface_trigonometric.py
antonwolfy
antonwolfy approved these changes Jan 10, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana !

@antonwolfy

antonwolfy commented Jan 10, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

But to be able to merge the PR we need to wait until the latest dpctl will be available in the internal channel, otherwise the tests in the internal CI will be always failing.

Vahid Tavanashadand others added 8 commits January 17, 2024 11:20
Vahid Tavanashad
implement dpnp.reciprocal and dpnp.angle
8dae602
Vahid Tavanashad
fix docstring
a58f76c
Vahid Tavanashad
skip umath test for reciprocal
da11aa7
Vahid Tavanashad
address comments
14eee49
Vahid Tavanashad
add a note for reciprocal
a6b5c05
@vtavana@antonwolfyVahid Tavanashad
Update dpnp/dpnp_iface_trigonometric.py
a6d8580
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Vahid Tavanashad
fix docstring
2e59ee9
Vahid Tavanashad
update retunrs for angle and reciprocal
98edb71
update out keyword implementation for angle and reciprocal to make it
consistent with implementation of other functions
@antonwolfy
antonwolfy merged commit b401ae9 into masterJan 20, 2024
@antonwolfy
antonwolfy deleted the reciprocal_angle branch January 20, 2024 17:32
@antonwolfyantonwolfy mentioned this pull request Feb 1, 2024
Merged
@antonwolfyantonwolfy mentioned this pull request May 31, 2024
Closed
99 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorianndgrigorianndgrigorian left review comments
@antonwolfyantonwolfyantonwolfy approved these changes

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana@antonwolfy@ndgrigorian