Skip to content

implement dpnp.nanmean, dpnp.nanstd, dpnp.nansum, and dpnp.average - #1654

Merged
antonwolfy merged 8 commits into
masterfrom
nanmean_nanstd_nansum_average
Jan 12, 2024
Merged

implement dpnp.nanmean, dpnp.nanstd, dpnp.nansum, and dpnp.average#1654
antonwolfy merged 8 commits into
masterfrom
nanmean_nanstd_nansum_average

Conversation

@vtavana

@vtavanavtavana commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

In this PR, dpnp.nanmean, dpnp.nanstd, dpnp.nansum, and dpnp.average are implemented using existing functions in dpnp.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Jan 9, 2024
@github-actions

github-actionsBot commented Jan 9, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana
vtavana marked this pull request as ready for review January 10, 2024 04:24
antonwolfy
antonwolfy reviewed Jan 10, 2024
View reviewed changes
Comment threaddpnp/dpnp_algo/dpnp_algo_mathematical.pxi
Comment threaddpnp/dpnp_iface_statistics.py Outdated
Comment threaddpnp/dpnp_iface_nanfunctions.py
Comment threaddpnp/dpnp_iface_nanfunctions.py Outdated
Comment threaddpnp/dpnp_iface_statistics.py
Comment threadtests/third_party/cupy/math_tests/test_sumprod.py Outdated
Comment threadtests/third_party/cupy/math_tests/test_sumprod.py
Comment threadtests/third_party/cupy/math_tests/test_sumprod.py
Comment threadtests/third_party/cupy/math_tests/test_sumprod.py
Comment threadtests/third_party/cupy/math_tests/test_sumprod.py Outdated
vtavana
vtavana commented Jan 10, 2024
View reviewed changes
Comment threadtests/third_party/cupy/math_tests/test_sumprod.py
antonwolfy
antonwolfy approved these changes Jan 12, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana LGTM!

Comment threadtests/test_mathematical.py Outdated
@antonwolfy
antonwolfy merged commit 3fdb921 into masterJan 12, 2024
@antonwolfy
antonwolfy deleted the nanmean_nanstd_nansum_average branch January 12, 2024 13:33
github-actionsBot added a commit that referenced this pull request Jan 12, 2024
@github-actions
implement dpnp.nanmean, dpnp.nanstd, dpnp.nansum, and `dpnp.ave…
f7ea30e
…rage` (#1654)
* implement dpnp.nanmean, dpnp.nanstd, dpnp.nansum and dpnp.average
* change size huge test case
* fix TestArithmetic test
* fix test nanmean
* address comments
* using assert_dtype_allclose
* add rtol to comparison
* Update tests/test_mathematical.py
---------
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 3fdb921
github-actionsBot added a commit to antonwolfy/dpnp that referenced this pull request Jan 12, 2024
@github-actions
implement dpnp.nanmean, dpnp.nanstd, dpnp.nansum, and `dpnp.ave…
b01162a
…rage` (IntelPython#1654)
* implement dpnp.nanmean, dpnp.nanstd, dpnp.nansum and dpnp.average
* change size huge test case
* fix TestArithmetic test
* fix test nanmean
* address comments
* using assert_dtype_allclose
* add rtol to comparison
* Update tests/test_mathematical.py
---------
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 3fdb921
@antonwolfyantonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana@antonwolfy