Skip to content

update out keyword for elementwise functions - #1656

Merged
vtavana merged 5 commits into
masterfrom
elementwise_out_keyword
Jan 17, 2024
Merged

update out keyword for elementwise functions#1656
vtavana merged 5 commits into
masterfrom
elementwise_out_keyword

Conversation

@vtavana

@vtavanavtavana commented Jan 13, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

In this PR, a bug related to out keyword in elementwise functions is fixed.
In the current implementation of the elementwise functions, the output of the function and the output coming from out keyword are two different copies of the same data. The code is modified to make the output of the function a view of the output corresponding to the out keyword.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Vahid Tavanashad
update out keyword elementwise
08fe8ba
update out keyword elementwise
@vtavanavtavana self-assigned this Jan 13, 2024
@github-actions

github-actionsBot commented Jan 13, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana
vtavana marked this pull request as draft January 13, 2024 19:28
@vtavana
vtavana marked this pull request as ready for review January 15, 2024 18:15
antonwolfy
antonwolfy reviewed Jan 17, 2024
View reviewed changes
Comment threaddpnp/dpnp_algo/dpnp_elementwise_common.py Outdated
antonwolfy
antonwolfy approved these changes Jan 17, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtavana. thank you for catching and resolving that!

@vtavana
vtavana merged commit 75f1f97 into masterJan 17, 2024
@vtavana
vtavana deleted the elementwise_out_keyword branch January 17, 2024 17:13
github-actionsBot added a commit that referenced this pull request Jan 17, 2024
@github-actions
updateoutkeyword for elementwise functions (#1656)
ae12292
* update out keyword elementwise
* improve test coverage
* address comments 75f1f97
@antonwolfyantonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana@antonwolfy