Skip to content

implement sort and argsort - #1660

Merged
antonwolfy merged 6 commits into
masterfrom
sort_argsort
Jan 22, 2024
Merged

implement sort and argsort#1660
antonwolfy merged 6 commits into
masterfrom
sort_argsort

Conversation

@vtavana

@vtavanavtavana commented Jan 17, 2024

Copy link
Copy Markdown
Contributor

In this PR, dpnp.sort and dpnp.argsort are implemented using their dcptl counterparts.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Jan 17, 2024
@github-actions

github-actionsBot commented Jan 17, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana
vtavana marked this pull request as ready for review January 17, 2024 21:38
vtavana
vtavana commented Jan 17, 2024
View reviewed changes
Comment threaddpnp/dpnp_iface_sorting.py Outdated
antonwolfy
antonwolfy reviewed Jan 19, 2024
View reviewed changes
Comment threaddpnp/dpnp_iface_sorting.py Outdated
Comment threaddpnp/dpnp_iface_sorting.py Outdated
Comment threaddpnp/dpnp_iface_sorting.py Outdated
Comment threaddpnp/dpnp_array.py
Comment threaddpnp/dpnp_iface_sorting.py
Comment threadtests/third_party/cupy/sorting_tests/test_sort.py Outdated
Comment threadtests/third_party/cupy/sorting_tests/test_sort.py
Comment threadtests/third_party/cupy/sorting_tests/test_sort.py Outdated
Comment threadtests/test_sort.py Outdated
Comment threadtests/test_sort.py Outdated
antonwolfy
antonwolfy approved these changes Jan 20, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have more comments, LGTM. Thank you @vtavana

@antonwolfy
antonwolfy merged commit 8072622 into masterJan 22, 2024
@antonwolfy
antonwolfy deleted the sort_argsort branch January 22, 2024 12:33
github-actionsBot added a commit to antonwolfy/dpnp that referenced this pull request Jan 22, 2024
@github-actions
implement sort and argsort (IntelPython#1660)
8fe8c1a
* implement sort and argsort
* add more tests
* update for zero dimensional arrays
* address comments
* fix typo 8072622
@antonwolfyantonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana@antonwolfy