Skip to content

update tests affected by changing TypeError to ValueError in dpctl - #1662

Merged
antonwolfy merged 3 commits into
masterfrom
update_tests
Jan 19, 2024
Merged

update tests affected by changing TypeError to ValueError in dpctl#1662
antonwolfy merged 3 commits into
masterfrom
update_tests

Conversation

@vtavana

@vtavanavtavana commented Jan 19, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

In this PR, elementwise tests are updated to align with recent changes in dpctlgh-1496.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Jan 19, 2024
@github-actions

github-actionsBot commented Jan 19, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

Vahid Tavanashad
update tests
d33ce7d
update more tests
rename varibale
update test hypot
antonwolfy
antonwolfy reviewed Jan 19, 2024
View reviewed changes
Comment threadtests/third_party/cupy/core_tests/test_ndarray_unary_op.py
@vtavana
vtavana marked this pull request as ready for review January 19, 2024 16:51
antonwolfy
antonwolfy approved these changes Jan 19, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vtavana

@antonwolfy
antonwolfy merged commit 0a5a2bd into masterJan 19, 2024
@antonwolfy
antonwolfy deleted the update_tests branch January 19, 2024 23:36
@antonwolfyantonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
@vlad-perevezentsevvlad-perevezentsevAwaiting requested review from vlad-perevezentsevvlad-perevezentsev is a code owner

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana@antonwolfy