Skip to content

Update dpnp.linalg.inv() function - #1665

Merged
vlad-perevezentsev merged 17 commits into
masterfrom
impl_inv_new
Jan 29, 2024
Merged

Update dpnp.linalg.inv() function#1665
vlad-perevezentsev merged 17 commits into
masterfrom
impl_inv_new

Conversation

@vlad-perevezentsev

@vlad-perevezentsevvlad-perevezentsev commented Jan 23, 2024

Copy link
Copy Markdown
Contributor

This PR update dpnp.linalg.inv() function to calculate the (multiplicative) inverse matrix using oneapi::mkl::lapack::gesv for 2d input matrix and oneapi::mkl::lapack::getrf_batch and oneapi::mkl::lapack::getri_batch for input array dimensions > 2.
The implementation is written as a pybind11 extension above required LAPACK functions.
The changes are related to support of all types and support of function arguments as full_matrices and compute_uv

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsevvlad-perevezentsev self-assigned this Jan 23, 2024
@github-actions

github-actionsBot commented Jan 23, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Jan 23, 2024
View reviewed changes
Comment threaddpnp/backend/extensions/lapack/getri_batch.cpp
Comment threaddpnp/backend/extensions/lapack/getri_batch.cpp
Comment threaddpnp/backend/kernels/dpnp_krnl_linalg.cpp
Comment threaddpnp/linalg/dpnp_utils_linalg.py Outdated
Comment threaddpnp/linalg/dpnp_utils_linalg.py Outdated
Comment threaddpnp/linalg/dpnp_utils_linalg.py Outdated
Comment threaddpnp/linalg/dpnp_utils_linalg.py Outdated
Comment threaddpnp/linalg/dpnp_utils_linalg.py Outdated
Comment threadtests/third_party/cupy/linalg_tests/test_solve.py Outdated
Comment threadtests/third_party/cupy/linalg_tests/test_solve.py
antonwolfy
antonwolfy reviewed Jan 25, 2024
View reviewed changes
Comment threaddpnp/linalg/dpnp_utils_linalg.py Outdated
antonwolfy
antonwolfy approved these changes Jan 29, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vlad-perevezentsev

@vlad-perevezentsev
vlad-perevezentsev merged commit 7a56304 into masterJan 29, 2024
@vlad-perevezentsev
vlad-perevezentsev deleted the impl_inv_new branch January 29, 2024 12:16
github-actionsBot added a commit to antonwolfy/dpnp that referenced this pull request Jan 29, 2024
@github-actions
Update dpnp.linalg.inv() function (IntelPython#1665)
f7c95c8
* Impl dpnp.linalg.inv for 2d array
* Remove an old impl of dpnp_inv
* Add batch implementation of dpnp.linalg.inv func
* Add cupy tests for dpnp.linalg.inf
* Add dpnp tests for dpnp.linalg.inv
* Add check_lapack_dev_info func
* Add dev_info size check for getri_batch and getrf_batch
* Add size check dev_info and error_matrices_ids
* Remove dpnp_inv_ext_c
* Rename check_lapack_dev_info to _check_lapack_dev_info
* Skip test_inv in TestInvInvalid
---------
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 7a56304
@antonwolfyantonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
@npolina4npolina4Awaiting requested review from npolina4
@vtavanavtavanaAwaiting requested review from vtavana

Assignees

@vlad-perevezentsevvlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlad-perevezentsev@antonwolfy