Skip to content

update dpnp.dot implementation - #1669

Merged
antonwolfy merged 15 commits into
masterfrom
dpnp_dot
Feb 6, 2024
Merged

update dpnp.dot implementation#1669
antonwolfy merged 15 commits into
masterfrom
dpnp_dot

Conversation

@vtavana

@vtavanavtavana commented Jan 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

In this PR, dpnp.dot is updated. 1) For integer and boolean data types, dpctl.tensor.vecdot form the Data Parallel Control library is used, 2) For real-valued floating point data types, dot routines from BLAS library of OneMKL are used, and 3) For complex data types, dotu routines from BLAS library of OneMKL are used.

Also, dpnp.matmul is updated to return a 1D array instead of 0D array when one of the inputs is 1D and the other one is inherently 1D.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Jan 25, 2024
@github-actions

github-actionsBot commented Jan 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana
vtavana marked this pull request as ready for review January 25, 2024 23:41
antonwolfy
antonwolfy reviewed Jan 26, 2024
View reviewed changes
Comment threaddpnp/backend/extensions/blas/dot.cpp
Comment threadtests/test_dot.py Outdated
Comment threadtests/test_dot.py Outdated
antonwolfy
antonwolfy reviewed Jan 29, 2024
View reviewed changes
Comment threaddpnp/dpnp_iface_linearalgebra.py
Comment threaddpnp/dpnp_iface_linearalgebra.py Outdated
Comment threaddpnp/dpnp_iface_linearalgebra.py
Comment threaddpnp/dpnp_iface_linearalgebra.py
Comment threaddpnp/dpnp_iface_linearalgebra.py
Comment threaddpnp/dpnp_iface_linearalgebra.py
Comment threaddpnp/dpnp_utils/dpnp_utils_linearalgebra.py Outdated
Comment threadtests/third_party/cupy/linalg_tests/test_product.py
Comment threadtests/third_party/cupy/linalg_tests/test_product.py
@vtavana

vtavana commented Feb 1, 2024

Copy link
Copy Markdown
ContributorAuthor

Timing on Iris Xe

image

antonwolfy
antonwolfy reviewed Feb 4, 2024
View reviewed changes
Comment threaddpnp/backend/extensions/blas/dot.cpp Outdated
Comment threaddpnp/dpnp_utils/dpnp_utils_linearalgebra.py Outdated
antonwolfy
antonwolfy approved these changes Feb 5, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana I don't have more comments.
@npolina4 , could you please check the dpench flow and reply here? And then if no issue, we will be able to merge the PR.

@npolina4npolina4 mentioned this pull request Feb 5, 2024
Closed
@antonwolfy

antonwolfy commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

The issue #1693 relate to previous changes in dpnp.matmul implementation, so the PR can be merged.

@antonwolfy
antonwolfy merged commit ac1fca7 into masterFeb 6, 2024
@antonwolfy
antonwolfy deleted the dpnp_dot branch February 6, 2024 12:06
github-actionsBot added a commit that referenced this pull request Feb 6, 2024
@github-actions
updatedpnp.dotimplementation (#1669)
5d9672e
* dot_func
* using mkl::dotu instead mkl::dotc for complex
* fix a test
* fix negative strides
* add a temporary workaround
* address comments
* add a TODO comment
* call dpt.vecdot for integer data types
* update doc string
* pass argument by reference
* update doc to add boolean dtype
---------
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> ac1fca7
github-actionsBot added a commit to antonwolfy/dpnp that referenced this pull request Feb 7, 2024
@github-actions
updatedpnp.dotimplementation (IntelPython#1669)
9354103
* dot_func
* using mkl::dotu instead mkl::dotc for complex
* fix a test
* fix negative strides
* add a temporary workaround
* address comments
* add a TODO comment
* call dpt.vecdot for integer data types
* update doc string
* pass argument by reference
* update doc to add boolean dtype
---------
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> ac1fca7
@antonwolfyantonwolfy mentioned this pull request Feb 10, 2024
Merged
@vlad-perevezentsevvlad-perevezentsev mentioned this pull request Jun 24, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
@vlad-perevezentsevvlad-perevezentsevAwaiting requested review from vlad-perevezentsevvlad-perevezentsev is a code owner

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana@antonwolfy