Skip to content

Implement sparse and copy arguments for dpnp.meshgrid function - #1675

Merged
antonwolfy merged 7 commits into
masterfrom
meshgrid_func
Feb 3, 2024
Merged

Implement sparse and copy arguments for dpnp.meshgrid function#1675
antonwolfy merged 7 commits into
masterfrom
meshgrid_func

Conversation

@npolina4

@npolina4npolina4 commented Jan 31, 2024•
edited by antonwolfy
Loading

Copy link
Copy Markdown
Contributor

Implement sparse and copy arguments for dpnp.mesgrid function

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions

github-actionsBot commented Jan 31, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

antonwolfy
antonwolfy reviewed Feb 1, 2024
View reviewed changes
Comment threaddpnp/dpnp_iface_arraycreation.py Outdated
Comment threaddpnp/dpnp_iface_arraycreation.py Outdated
Comment threaddpnp/dpnp_iface_arraycreation.py Outdated
Comment threaddpnp/dpnp_iface_arraycreation.py Outdated
Comment threaddpnp/dpnp_iface_arraycreation.py Outdated
antonwolfy
antonwolfy approved these changes Feb 2, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4

antonwolfy
antonwolfy reviewed Feb 2, 2024
View reviewed changes
Comment threaddpnp/dpnp_iface_arraycreation.py
Comment threaddpnp/dpnp_iface_arraycreation.py
@antonwolfy
antonwolfy merged commit 7c4b39a into masterFeb 3, 2024
@antonwolfy
antonwolfy deleted the meshgrid_func branch February 3, 2024 14:29
github-actionsBot added a commit to antonwolfy/dpnp that referenced this pull request Feb 3, 2024
@github-actions@antonwolfy
Implement sparse and copy arguments for dpnp.mesgrid function (IntelP…
ee0a8bc
…ython#1675)
* Implement sparse and copy arguments for dpnp.mesgrid function
* address comments
* Removed limitation block from th description
* added tests
---------
Co-authored-by: Anton Volkov <antonwolfy@gmail.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 7c4b39a
@antonwolfyantonwolfy changed the title Implement sparse and copy arguments for dpnp.mesgrid functionImplement sparse and copy arguments for dpnp.meshgrid functionFeb 10, 2024
@antonwolfyantonwolfy mentioned this pull request Feb 10, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
@vtavanavtavanaAwaiting requested review from vtavana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@npolina4@antonwolfy