Skip to content

Add raises NotImplementedError for array creation functions - #1695

Merged
antonwolfy merged 6 commits into
masterfrom
not_implemented_error
Feb 13, 2024
Merged

Add raises NotImplementedError for array creation functions#1695
antonwolfy merged 6 commits into
masterfrom
not_implemented_error

Conversation

@npolina4

@npolina4npolina4 commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

Add raises NotImplementedError for array creation functions
Update dpnp.tri, dpnp.tril, and dpnp.triu implementation and errors
Add tests

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions

github-actionsBot commented Feb 6, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Feb 6, 2024
View reviewed changes
Comment threadtests/skipped_tests.tbl Outdated
Comment threaddpnp/dpnp_iface.py Outdated
Comment threaddpnp/dpnp_iface_arraycreation.py Outdated
antonwolfy
antonwolfy reviewed Feb 7, 2024
View reviewed changes
Comment threaddpnp/dpnp_iface_arraycreation.py
Comment threaddpnp/dpnp_iface_arraycreation.py
Comment threaddpnp/dpnp_iface_arraycreation.py Outdated
antonwolfy
antonwolfy reviewed Feb 8, 2024
View reviewed changes
Comment threaddpnp/dpnp_iface_arraycreation.py
antonwolfy
antonwolfy reviewed Feb 10, 2024
View reviewed changes
Comment threaddpnp/dpnp_iface_arraycreation.py Outdated
antonwolfy
antonwolfy approved these changes Feb 12, 2024
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4

@antonwolfy
antonwolfy merged commit 4f4db77 into masterFeb 13, 2024
@antonwolfy
antonwolfy deleted the not_implemented_error branch February 13, 2024 09:11
github-actionsBot added a commit that referenced this pull request Feb 13, 2024
@github-actions
Add raises NotImplementedError for array creation functions (#1695)
d000f4b
* Add raises NotImplementedError for array creation functions
* address comments
* address comments
* Added value error for order A and K. Changed test for exceptions
* Fix pre-commit 4f4db77
antonwolfy added a commit that referenced this pull request Feb 15, 2024
@antonwolfy
Added#1699,#1690and#1695
f47d935
antonwolfy added a commit that referenced this pull request Feb 15, 2024
@antonwolfy
Preparation for0.14.0rc1tag (#1711)
b95b89c
* Added #1699, #1690 and #1695
* Stepped dpctl version in all dependencies
@antonwolfyantonwolfy mentioned this pull request Feb 15, 2024
Merged
github-actionsBot added a commit to antonwolfy/dpnp that referenced this pull request Feb 15, 2024
@github-actions
Preparation for0.14.0rc1tag (IntelPython#1711)
ced5ae9
* Added IntelPython#1699, IntelPython#1690 and IntelPython#1695
* Stepped dpctl version in all dependencies b95b89c
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
@vlad-perevezentsevvlad-perevezentsevAwaiting requested review from vlad-perevezentsevvlad-perevezentsev is a code owner
@vtavanavtavanaAwaiting requested review from vtavana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@npolina4@antonwolfy