Replace use of queue mgr by oleksandr-pavlyk · Pull Request #1735 · IntelPython/dpnp

oleksandr-pavlyk · 2024-03-01T16:59:43Z

DPCTLQueueMgr_* is being removed, see IntelPython/dpctl#1576.

This PR removes use of DPCTLQueueMgr_* in queue_sycl.cpp and queue_sycl.hpp.

It effectively reverts to using DPNP_LOCAL_QUEUE=1.

Examples, documentation were also updated to avoid uses of device_selector as it is being removed.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you filing the PR as a draft?

github-actions · 2024-03-01T17:23:28Z

View rendered docs @ https://intelpython.github.io/dpnp/index.html

This is done by reverting to DPNP_LOCAL_QUEUE=1 behavior. The ultimate goal is to get rid of DPNP_QUEUE throughout dpnp codebase

Since DPNP_LOCAL_QUEUE has been removed.

oleksandr-pavlyk · 2024-03-17T02:38:48Z

This change should not have made any difference, but please see if tests say otherwise.

Renamed backend_sycl_singleton back to backend_sycl Removed dpnp_queue_initialize_c function and QueueOptions enum as no longer used. Removed uses of these from examples and code base

antonwolfy

@oleksandr-pavlyk, thanks a lot for implementing a proper local queue handing in dpnp.

oleksandr-pavlyk · 2024-03-20T11:46:28Z

@antonwolfy Are we good to merge?

antonwolfy

I don't have any comment. Thank you @oleksandr-pavlyk

@diptorupd

* Remove use of deprecated DPCTLQueueMgr_* functions This is done by reverting to DPNP_LOCAL_QUEUE=1 behavior. The ultimate goal is to get rid of DPNP_QUEUE throughout dpnp codebase * Removed setting DPNP_LOCAL_QUEUE in tests Since DPNP_LOCAL_QUEUE has been removed. * Removed uses of device_context * Removed trailing whitespace * Replaced tab with spaces * Use backend_sycl_singleton, remove backend_sycl * Removed pre-preprocessor fenced out dead code Renamed backend_sycl_singleton back to backend_sycl Removed dpnp_queue_initialize_c function and QueueOptions enum as no longer used. Removed uses of these from examples and code base * Formatting suggested by pre-commit hooks * Addressed issues raised by @diptorupd --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> b51100f

@diptorupd

* Remove use of deprecated DPCTLQueueMgr_* functions This is done by reverting to DPNP_LOCAL_QUEUE=1 behavior. The ultimate goal is to get rid of DPNP_QUEUE throughout dpnp codebase * Removed setting DPNP_LOCAL_QUEUE in tests Since DPNP_LOCAL_QUEUE has been removed. * Removed uses of device_context * Removed trailing whitespace * Replaced tab with spaces * Use backend_sycl_singleton, remove backend_sycl * Removed pre-preprocessor fenced out dead code Renamed backend_sycl_singleton back to backend_sycl Removed dpnp_queue_initialize_c function and QueueOptions enum as no longer used. Removed uses of these from examples and code base * Formatting suggested by pre-commit hooks * Addressed issues raised by @diptorupd --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> b51100f

oleksandr-pavlyk requested review from antonwolfy, npolina4 and vtavana March 16, 2024 11:52

oleksandr-pavlyk added 5 commits March 16, 2024 20:15

Remove use of deprecated DPCTLQueueMgr_* functions
6db800d
This is done by reverting to DPNP_LOCAL_QUEUE=1 behavior. The ultimate goal is to get rid of DPNP_QUEUE throughout dpnp codebase

Removed setting DPNP_LOCAL_QUEUE in tests
b578f87
Since DPNP_LOCAL_QUEUE has been removed.

Removed uses of device_context
6309f26

Removed trailing whitespace
67867d8

Replaced tab with spaces
c11b779

oleksandr-pavlyk force-pushed the replace-use-of-queue-mgr branch from db48050 to 6309f26Compare March 17, 2024 02:17

oleksandr-pavlyk added 3 commits March 18, 2024 13:16

Use backend_sycl_singleton, remove backend_sycl
814ad56

Removed pre-preprocessor fenced out dead code
bf24b22
Renamed backend_sycl_singleton back to backend_sycl Removed dpnp_queue_initialize_c function and QueueOptions enum as no longer used. Removed uses of these from examples and code base

Formatting suggested by pre-commit hooks
ac1b43a

antonwolfy reviewed Mar 19, 2024
View reviewed changes

Comment threaddpnp/backend/src/queue_sycl.hpp Outdated
Comment threaddpnp/backend/src/queue_sycl.hpp Outdated

oleksandr-pavlyk force-pushed the replace-use-of-queue-mgr branch from 2c266f9 to ac1b43aCompare March 19, 2024 13:10

antonwolfy approved these changes Mar 19, 2024
View reviewed changes

antonwolfyand others added 2 commits March 19, 2024 14:17

Merge branch 'master' into replace-use-of-queue-mgr
d479168

Addressed issues raised by@diptorupd
f9b1db7

oleksandr-pavlyk requested a review from diptorupd March 19, 2024 15:56

diptorupd reviewed Mar 19, 2024
View reviewed changes

Comment threaddpnp/backend/src/queue_sycl.hpp Outdated

diptorupd reviewed Mar 19, 2024
View reviewed changes

Comment threaddpnp/backend/src/queue_sycl.hpp Outdated

oleksandr-pavlyk requested review from antonwolfy and diptorupd March 19, 2024 19:06

antonwolfy approved these changes Mar 20, 2024
View reviewed changes

antonwolfy merged commit b51100f into masterMar 20, 2024

antonwolfy deleted the replace-use-of-queue-mgr branch March 20, 2024 12:09

oleksandr-pavlyk mentioned this pull request Mar 20, 2024
Remove the DPCTLQueueMgr_* and device_context API from dpctl IntelPython/dpctl#1576
Merged
6 tasks

Navigation Menu

Uh oh!

Replace use of queue mgr - #1735

Replace use of queue mgr#1735
antonwolfy merged 10 commits into
masterfrom
replace-use-of-queue-mgr

oleksandr-pavlyk commented Mar 1, 2024

Uh oh!

github-actionsBot commented Mar 1, 2024•
edited
Loading

Uh oh!

oleksandr-pavlyk commented Mar 17, 2024

Uh oh!

Uh oh!

Uh oh!

antonwolfy left a comment

Uh oh!

Uh oh!

Uh oh!

oleksandr-pavlyk commented Mar 20, 2024

Uh oh!

antonwolfy left a comment •
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

oleksandr-pavlyk commented Mar 1, 2024

Uh oh!

github-actionsBot commented Mar 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oleksandr-pavlyk commented Mar 17, 2024

Uh oh!

Uh oh!

Uh oh!

antonwolfy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

oleksandr-pavlyk commented Mar 20, 2024

Uh oh!

antonwolfy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actionsBot commented Mar 1, 2024•
edited
Loading

antonwolfy left a comment •
edited
Loading