Uh oh!
There was an error while loading. Please reload this page.
Permit "same_kind" casting for element-wise in-place operators - #2170
Merged
Conversation
Contributor
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfyforce-pushed
the
in-place-element-wise-func-casting
branch
2 times, most recently
from
November 25, 2024 15:49
5cb5319 to
9a41bf9Compareantonwolfyforce-pushed
the
in-place-element-wise-func-casting
branch
from
November 26, 2024 12:36
ee5c848 to
86d5c69Compareantonwolfy
marked this pull request as ready for review
November 26, 2024 13:16
antonwolfy
requested review from
AlexanderKalistratov, vlad-perevezentsev and vtavana
as code ownersNovember 26, 2024 13:16
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
AlexanderKalistratov
approved these changes
Jan 10, 2025
github-actionsBot
added a commit
that referenced
this pull request
Jan 11, 2025
The PR proposes to permit `"same_kind"` casting for element-wise in-place operators. The implementation leverages on dpctl changes added in scope of [PR#1827](IntelPython/dpctl#1827). It also adds callbacks to support in-place bit-wise operators (leverages on dpctl changes from [RR#1447](IntelPython/dpctl#1447)). The PR removes a temporary workaround from `dpnp.wrap` which depends on the implemented changes. 3d02b6b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR proposes to permit
"same_kind"casting for element-wise in-place operators. The implementation leverages on dpctl changes added in scope of PR#1827.It also adds callbacks to support in-place bit-wise operators (leverages on dpctl changes from RR#1447).
The PR removes a temporary workaround from
dpnp.wrapwhich depends on the implemented changes.