Skip to content

update test_sycl_queue.py file - #2315

Merged
vtavana merged 4 commits into
masterfrom
update-test_sycl_queue
Feb 15, 2025
Merged

update test_sycl_queue.py file#2315
vtavana merged 4 commits into
masterfrom
update-test_sycl_queue

Conversation

@vtavana

@vtavanavtavana commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

In this PR, test_sycl_queue.py is update to remove comparison with numpy results. The correctness of dpnp functions is separately validated in other tests. In this file, only compute-follow-data paradigm should be validated.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavanavtavana self-assigned this Feb 14, 2025
@github-actions

github-actionsBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana commented Feb 14, 2025
View reviewed changes
Comment threaddpnp/tests/test_sycl_queue.py
vtavana
vtavana commented Feb 14, 2025
View reviewed changes
Comment threaddpnp/tests/test_sycl_queue.py Outdated
@github-actions

github-actionsBot commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_19 ran successfully.
Passed: 991
Failed: 1
Skipped: 22

@coveralls

coveralls commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 71.742%. remained the same
when pulling fe8edd1 on update-test_sycl_queue
into 131e4e0 on master.

@vtavana
vtavana marked this pull request as ready for review February 14, 2025 16:59
antonwolfy
antonwolfy reviewed Feb 15, 2025
View reviewed changes
Comment threaddpnp/tests/test_sycl_queue.py Outdated
antonwolfy
antonwolfy reviewed Feb 15, 2025
View reviewed changes
Comment threaddpnp/tests/test_sycl_queue.py Outdated
antonwolfy
antonwolfy approved these changes Feb 15, 2025
View reviewed changes

@antonwolfyantonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana
vtavana merged commit b6cc5fe into masterFeb 15, 2025
@vtavana
vtavana deleted the update-test_sycl_queue branch February 15, 2025 21:19
github-actionsBot added a commit that referenced this pull request Feb 15, 2025
@github-actions
updatetest_sycl_queue.pyfile (#2315)
d7a171a
In this PR, `test_sycl_queue.py` is update to remove comparison with
`numpy` results. The correctness of `dpnp` functions is separately
validated in other tests. In this file, only compute-follow-data
paradigm should be validated. b6cc5fe
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy approved these changes
@AlexanderKalistratovAlexanderKalistratovAwaiting requested review from AlexanderKalistratov
@vlad-perevezentsevvlad-perevezentsevAwaiting requested review from vlad-perevezentsevvlad-perevezentsev is a code owner
@ndgrigorianndgrigorianAwaiting requested review from ndgrigorianndgrigorian is a code owner

Assignees

@vtavanavtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana@coveralls@antonwolfy