Skip to content

Remove obsolete LIB/INCLUDE workaround from Windows conda build script - #3013

Merged
antonwolfy merged 3 commits into
masterfrom
remove-compiler-w/a-to-dpnp-bld.bat
Aug 7, 2026
Merged

Remove obsolete LIB/INCLUDE workaround from Windows conda build script#3013
antonwolfy merged 3 commits into
masterfrom
remove-compiler-w/a-to-dpnp-bld.bat

Conversation

@antonwolfy

@antonwolfyantonwolfy commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Removes a stale workaround from conda-recipe/bld.bat that manually prepended BUILD_PREFIX paths onto the Windows LIB and INCLUDE environment variables.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfyantonwolfy self-assigned this Aug 6, 2026
@github-actions

github-actionsBot commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfyantonwolfy changed the title Remove compiler w/a to include path to the compiler headersRemove obsolete LIB/INCLUDE workaround from Windows conda build scriptAug 6, 2026
@antonwolfyantonwolfy added this to the 0.21.0 release milestone Aug 6, 2026
@github-actions

github-actionsBot commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.21.0dev3=py314h509198e_38 ran successfully.
Passed: 1375
Failed: 2
Skipped: 5

@antonwolfy
antonwolfy marked this pull request as ready for review August 6, 2026 12:57
@coveralls

coveralls commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 78.414%. remained the same — remove-compiler-w/a-to-dpnp-bld.bat into master

ndgrigorian
ndgrigorian approved these changes Aug 6, 2026
View reviewed changes

@ndgrigorianndgrigorian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndgrigorianndgrigorian mentioned this pull request Aug 6, 2026
Open
8 tasks
@antonwolfy
antonwolfy merged commit 270892c into masterAug 7, 2026
70 of 78 checks passed
@antonwolfy
antonwolfy deleted the remove-compiler-w/a-to-dpnp-bld.bat branch August 7, 2026 13:37
github-actionsBot added a commit that referenced this pull request Aug 7, 2026
@github-actions
Remove obsolete LIB/INCLUDE workaround from Windows conda build script (
9012516
#3013)
Removes a stale workaround from `conda-recipe/bld.bat` that manually
prepended `BUILD_PREFIX` paths onto the Windows `LIB` and `INCLUDE`
environment variables. 270892c
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorianndgrigorianndgrigorian approved these changes
@vlad-perevezentsevvlad-perevezentsevAwaiting requested review from vlad-perevezentsevvlad-perevezentsev is a code owner

Assignees

@antonwolfyantonwolfy

Labels

None yet

Projects

None yet

Milestone

0.21.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy@coveralls@ndgrigorian