Move build system to `meson-python` by ndgrigorian · Pull Request #174 · IntelPython/mkl-service

ndgrigorian · 2026-04-08T02:34:35Z

This PR proposes moving from setuptools to meson-python as the mkl-service build system

meson-python is already used by NumPy and allows setup.py to be removed (with its logic moved into the meson.build script)

Copilot

Pull request overview

This PR migrates mkl-service from a setuptools/setup.py-driven build to a meson-python build, updating conda recipes and CI workflows accordingly, and adding an mkl runtime dependency.

Changes:

Remove setup.py and define extension builds/install layout in meson.build (C + Cython extensions, Python sources, tests).
Switch pyproject.toml build backend to mesonpy and add mkl to runtime dependencies.
Update conda recipes and GitHub Actions workflows to build/install via pip/python -m build instead of setup.py.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
setup.py	Removed legacy setuptools build script.
pyproject.toml	Switched build backend to `mesonpy`, updated build requirements and runtime deps.
meson.build	Added Meson build definition for C/Cython extensions and installation layout.
mkl/_py_mkl_service.pyx	Added/introduced Cython wrapper implementation used by the public API.
conda-recipe/meta.yaml	Updated conda build requirements for Meson-based builds.
conda-recipe/build.sh	Updated wheel build/install flow (no `setup.py`).
conda-recipe/bld.bat	Removed `setup.py` clean step and MKLROOT usage.
conda-recipe-cf/meta.yaml	Updated conda-forge recipe host requirements for Meson-based builds.
conda-recipe-cf/build.sh	Switched to `pip install .` build/install flow.
conda-recipe-cf/bld.bat	Switched to `pip install .` build/install flow.
.github/workflows/build-with-standard-clang.yml	New CI job building with system clang.
.github/workflows/build-with-clang.yml	Updated IntelLLVM clang CI job to Meson-based install.
.github/workflows/build_pip.yml	New CI job testing editable install + (pre-)release NumPy in conda env.

…[project].dependencies`

jharlow-intel

Everything is good, but small README change request

antonwolfy · 2026-07-16T07:59:41Z

@jharlow-intel, please let me know if you have more comments

vlad-perevezentsev · 2026-07-20T14:27:52Z

No more comments from my side
LGTM
Thank you @ndgrigorian @antonwolfy

jharlow-intel

This looks good to me! Only question is to keep python 3.10 support in or not but it'll be easy to pluck out later if we have to

…er than `install_rpath`. Meson rewrites `install_rpath` at install time (and the value is further mangled by conda-build relocation), which leaves published wheels without a working `$ORIGIN` entry. Passing `-Wl,-rpath,...` directly writes the RPATH into the binary verbatim -- matching the legacy setuptools behaviour -- so the wheel locates the MKL runtime without any post-build tooling.

…ntentionally doesn't emit a standalone wheel (conda-forge distributes conda packages, not wheels)

ndgrigorian requested review from antonwolfy, jharlow-intel and xaleryb as code owners April 8, 2026 02:34

ndgrigorian marked this pull request as draft April 8, 2026 03:59

ndgrigorian force-pushed the use-meson-build branch 4 times, most recently from 1f7006a to e209e46Compare April 8, 2026 06:35

ndgrigorian marked this pull request as ready for review April 8, 2026 06:51

Base automatically changed from drop-removed-cbwr-constants to masterApril 8, 2026 17:17

CopilotAI review requested due to automatic review settings April 8, 2026 18:20

ndgrigorian force-pushed the use-meson-build branch from e209e46 to dfc8f4cCompare April 8, 2026 18:20

Copilotstarted reviewing on behalf of ndgrigorian April 8, 2026 18:21 View session

CopilotAI reviewed Apr 8, 2026
View reviewed changes

ndgrigorian force-pushed the use-meson-build branch 3 times, most recently from b3cd7c9 to 3fb7affCompare April 11, 2026 03:05