Skip to content

add an interface for dask.fft - #214

Open
vtavana wants to merge 2 commits into
masterfrom
dask-interface
Open

add an interface for dask.fft#214
vtavana wants to merge 2 commits into
masterfrom
dask-interface

Conversation

@vtavana

@vtavanavtavana commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

address #5

@vtavanavtavana self-assigned this Aug 13, 2025
@vtavana
vtavanaforce-pushed the dask-interface branch 2 times, most recently from 90578c9 to 647d164CompareAugust 13, 2025 13:21
@vtavana
vtavana marked this pull request as ready for review August 28, 2025 12:08
CopilotAI review requested due to automatic review settings August 28, 2025 12:08

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Dask interface for the mkl_fft package, providing a drop-in replacement for the dask.fft module that leverages Intel MKL's optimized FFT implementations.

  • Implements mkl_fft.interfaces.dask_fft module with all FFT functions wrapped using Dask's fft_wrap
  • Adds comprehensive test suite for the new Dask interface functionality
  • Updates build configuration and documentation to support the new interface

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
pyproject.tomlAdds dask_interface optional dependency and includes dask in test dependencies
mkl_fft/interfaces/dask_fft.pyNew module implementing Dask FFT interface by wrapping numpy_fft functions
mkl_fft/tests/third_party/dask/test_dask_fft.pyComprehensive test suite for Dask FFT functionality
mkl_fft/tests/test_interfaces.pyUpdates interface tests to include Dask FFT
mkl_fft/interfaces/init.pyConditionally imports dask_fft module when Dask is available
mkl_fft/interfaces/README.mdAdds documentation for the new Dask interface
conda-recipe/meta.yamlUpdates conda recipe to include dask test dependency and import test
conda-recipe-cf/meta.yamlUpdates conda-forge recipe similarly
CHANGELOG.mdDocuments the new Dask interface feature
.github/workflows/*.ymlUpdates CI workflows to include dask as test dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@IntelPythonIntelPython deleted a comment from CopilotAIAug 28, 2025
@IntelPythonIntelPython deleted a comment from CopilotAIAug 28, 2025
@IntelPythonIntelPython deleted a comment from CopilotAIAug 28, 2025

@jharlow-inteljharlow-intel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some conflicts need to be resolved.

It's okay that the 3.14 internal CI is broken for now, though

@ndgrigorian

Copy link
Copy Markdown
Collaborator

@antonwolfy@jharlow-intel
addressed conflicts, we can get this in now

@ndgrigorian

Copy link
Copy Markdown
Collaborator

changes in the workflows made it more convenient to put this on top of the conda-forge recipe updates, this can go in after that

@ndgrigorian

Copy link
Copy Markdown
Collaborator

@jharlow-intel@antonwolfy ready for review

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vtavana@ndgrigorian@jharlow-intel