Uh oh!
There was an error while loading. Please reload this page.
Make mkl-service an optional dependency - #305
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes mkl-service optional by moving it into the scipy_interface/test extras and conditionally exposing the SciPy adapter only when both SciPy and the mkl Python module (from mkl-service) are present.
Changes:
- Moves
mkl-serviceout of core dependencies and into optional extras inpyproject.toml. - Updates
mkl_fft.interfacesto only import/exportscipy_fftwhen both SciPy andmkl-serviceare available. - Adjusts conda recipes and CI workflows to install
mkl-serviceexplicitly for SciPy-related testing.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml | Shifts mkl-service into extras and changes base dependency set. |
mkl_fft/interfaces/__init__.py | Adds runtime checks to gate the SciPy interface export. |
conda-recipe/meta.yaml | Moves runtime MKL dependency to mkl and adds mkl-service to test requirements. |
conda-recipe-cf/meta.yaml | Same dependency adjustments for conda-forge recipe. |
.github/workflows/conda-package.yml | Ensures mkl-service is installed for test envs that include SciPy. |
.github/workflows/conda-package-cf.yml | Same test-environment adjustments for conda-forge workflow. |
.github/workflows/build_pip.yaml | Updates MKL install and adds explicit mkl-service install for tests (currently redundant with extras). |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aaf2822 to
81767b3Comparemkl-service is only a dependency for the sake of the scipy interface, which is optional
81767b3 to
a8169a5Compare
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian, LGTM
The only nit is the changelog update.
514c799 to
33d2698CompareUh oh!
There was an error while loading. Please reload this page.
mkl-serviceis only a dependency for the sake of thescipyinterface, which is optionalThis PR proposes moving
mkl-serviceto optionally installable and adding logic to check for bothmkl-serviceandscipyin the environment before exposing thescipyinterface.These changes also add
del scipyanddel mklto the interfaces__init__, which removes namespace pollution