Skip to content

Move build system to meson-python - #113

Open
ndgrigorian wants to merge 43 commits into
masterfrom
build-with-meson
Open

Move build system to meson-python#113
ndgrigorian wants to merge 43 commits into
masterfrom
build-with-meson

Conversation

@ndgrigorian

@ndgrigorianndgrigorian commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

This PR proposes moving from setuptools to meson-python as the mkl_random build system

meson-python is already used by NumPy and allows setup.py to be removed (with its logic moved into the meson.build script)

@ndgrigorianndgrigorian reopened this Apr 7, 2026
@ndgrigorian
ndgrigorianforce-pushed the build-with-meson branch 3 times, most recently from b26da80 to 383dd0fCompareApril 8, 2026 03:56
@ndgrigorian
ndgrigorian marked this pull request as ready for review April 8, 2026 06:51
@ndgrigorian
Moves the build system from setuptools to meson
04605fe
* removes setup.py and generate_mklrand_c.py
* updates pyproject.toml
* adds meson.build
@ndgrigorian
add cmake to build system dependencies
a8429b3
we search for MKL with cmake. Also drop pkg-config from meta.yamls and use cmake
@ndgrigorian
use meson-python in builds
dd8fb6c
@ndgrigorian
add pip build
e7b7b56
@ndgrigorian
add standard clang workflow
2d1f4a4
remove tbb from build-with-clang workflow
@ndgrigorian
add ninja to build system and meta.yamls
6b6bc71
@ndgrigorian
use pip install in build scripts
668fbb5
aligns more closely with conda-forge feedstock
@ndgrigorian
remove MKLROOT
6f8d749
@ndgrigorian
don't install mkl-service in pip and standard clang builds
02efc61
@antonwolfyantonwolfy added this to the 1.5.0 release milestone Jun 24, 2026
@antonwolfyantonwolfy mentioned this pull request Jul 28, 2026
Merged
antonwolfy
antonwolfy reviewed Aug 3, 2026
View reviewed changes
Comment threadmeson.build Outdated
Comment threadmeson.build
Comment thread.github/workflows/build_pip.yml Outdated
Comment threadconda-recipe/build.sh Outdated
Comment threadpyproject.toml Outdated
authors = [
{name = "Intel Corporation", email = "scripting@intel.com"}
]
authors = [{name = "Intel Corporation"}]

@antonwolfyantonwolfyAug 3, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the email dropped intentionally?

@ndgrigorianndgrigorianAug 4, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped it because I have no access or insight into what this email address does or is used for

@antonwolfyantonwolfyAug 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me either, we probably need to doublecheck that.

@ndgrigorianndgrigorianAug 5, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems email is still in use, so we should add it back here @vlad-perevezentsev

antonwolfy
antonwolfy reviewed Aug 5, 2026
View reviewed changes
Comment threadpyproject.toml
requires = ["setuptools>=77", "Cython", "numpy"]
build-backend = "mesonpy"
requires = [
"meson-python>=0.16.0",

@antonwolfyantonwolfyAug 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we align with meson.build?

Suggested change
"meson-python>=0.16.0",
"meson-python>=1.8.3",

@vlad-perevezentsevvlad-perevezentsevAug 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meson and meson-python are different packages.
meson-python>=0.16.0 is the correct pin because it is the minimum backend version with PEP 639 SPDX license support
Same as in mkl_umath
https://github.com/IntelPython/mkl_umath/blob/main/pyproject.toml#L29

Comment threadconda-recipe-cf/meta.yaml Outdated
Comment threadmeson.build
@ndgrigorian

ndgrigorian commented Aug 5, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@vlad-perevezentsev
since we are supporting OSX, can we add OSX builds to the conda package workflow in the scope of this PR, similar to how it was done in mkl-service?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfyantonwolfyantonwolfy left review comments
@xalerybxalerybAwaiting requested review from xalerybxaleryb is a code owner
@jharlow-inteljharlow-intelAwaiting requested review from jharlow-inteljharlow-intel is a code owner
@vlad-perevezentsevvlad-perevezentsevAwaiting requested review from vlad-perevezentsevvlad-perevezentsev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.5.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian@vlad-perevezentsev@antonwolfy