Skip to content
This repository was archived by the owner on Jul 13, 2026. It is now read-only.

Rename dppl to dppy - #42

Merged
PokhodenkoSA merged 7 commits into
IntelPython:mainfrom
1e-to:rename
Dec 7, 2020
Merged

Rename dppl to dppy#42
PokhodenkoSA merged 7 commits into
IntelPython:mainfrom
1e-to:rename

Conversation

@1e-to

@1e-to1e-to commented Dec 3, 2020

Copy link
Copy Markdown
Contributor

Closes the issue #8

Files in which it was not possible to rename, due to connection with dpCtl:

  • numba_dppy/dppy_host_fn_call_gen.py
  • numba_dppy/experimental_numpy_lowering_overload.py
  • numba_dppy/initialize.py

Locally tested:
Ran 140 tests in 28.366s
OK (skipped=26, expected failures=1)

@PokhodenkoSAPokhodenkoSA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update with main branch. It will fix CI.

@1e-to

1e-to commented Dec 4, 2020

Copy link
Copy Markdown
ContributorAuthor

I'll tested it with IntelPython/dpctl#201

Ran 140 tests in 28.973s
OK (skipped=26, expected failures=1)

dpctl 0.3.8+100.gba65df7 pypi_0 pypi

@diptorupddiptorupd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from minor changes. LGTM!

Comment threadnumba_dppy/__init__.py Outdated
Comment threadnumba_dppy/__init__.py Outdated
from .device_init import *
else:
raise ImportError("Importing dppl failed")
raise ImportError("Importing dppy failed")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numba-dppy instead of dppy. Our extension package is called numba-dppy.

@diptorupd

diptorupd commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

@PokhodenkoSA I have merged master and made couple of changes to let numba-dppy build with dpctl/master. For CI, do we need to tag a new RC candidate for dpctl and merge it to gold/2021?

Comment threadconda-recipe/meta.yaml Outdated
run:
- python
- numba >=0.51
- cffi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- cffi

Comment threadsetup.py Outdated
build_requires = ["cython"]
install_requires = [
"numba",
"cffi",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"cffi",

Comment on lines +8 to +9
# from numba_dppy.tests.dppy import *

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean commented code.

@PokhodenkoSAPokhodenkoSA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that branch is not up tp date with main branch.

@PokhodenkoSA
PokhodenkoSA merged commit ff8fe55 into IntelPython:mainDec 7, 2020
DrTodd13 pushed a commit that referenced this pull request Dec 10, 2020
Co-authored-by: etotmeni <elena.totmenina@intel.com>
Co-authored-by: Diptorup Deb <diptorup.deb@intel.com>
@PokhodenkoSAPokhodenkoSA mentioned this pull request Dec 15, 2020
@1e-to
1e-to deleted the rename branch November 3, 2021 11:54
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename dppl to dppy

3 participants

@1e-to@diptorupd@PokhodenkoSA