Skip to content

initial alignment of configs to final results - #176

Merged
ethanglaser merged 12 commits into
large-scalefrom
dev/eglaser-large-configs
Mar 21, 2025
Merged

initial alignment of configs to final results#176
ethanglaser merged 12 commits into
large-scalefrom
dev/eglaser-large-configs

Conversation

@ethanglaser

@ethanglaserethanglaser commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Description

Just configs so far, logic to be added (not ready for merge yet)


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@ethanglaserethanglaser mentioned this pull request Mar 21, 2025
9 tasks
@ethanglaser
ethanglaser marked this pull request as ready for review March 21, 2025 17:18
Comment threadsklbench/utils/measurement.py Outdated
Comment threadsklbench/utils/measurement.py Outdated
Comment threadsklbench/utils/measurement.py Outdated
Comment threadsklbench/utils/measurement.py Outdated
Comment threadsklbench/utils/measurement.py Outdated
@ethanglaser
ethanglaser merged commit 30b0b80 into large-scaleMar 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ethanglaser@KateBlueSky