Uh oh!
There was an error while loading. Please reload this page.
Generated Guidelines XML from the CSV file - #125
Merged
Conversation
Keboo
reviewed
Oct 3, 2020
| <root> | ||
| <guideline key="Ch01_fa67753" severity="DO" section="Naming" subsection="Variables and fields">DO favor clarity over brevity when naming identifiers.</guideline> | ||
| <guideline key="Ch01_674fe1e" severity="DO NOT" section="Naming" subsection="Abbreviations">DO NOT use abbreviations or contractions within identifier names.</guideline> | ||
| <guideline key="Ch01_024aa0c" severity="UNKNOWN ARGL" section="Naming" subsection="Abbreviations">"DO NOT use any acronyms unless they are widely accepted, and even then use them consistently."</guideline> |
Contributor
There was a problem hiding this comment.
It looks like the severity on several of these items is set to UNKNOWN ARGL. From looking over the items it appears that it is likely caused by the leading quotation marks
ContributorAuthor
There was a problem hiding this comment.
@Keboo oh you are right, with the quotes the automatic recognition of the severtiy didn't work correctly. I will fix this.
frosch95
commented
Oct 3, 2020
ContributorAuthor
You are welcome :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#123