Uh oh!
There was an error while loading. Please reload this page.
Update JS Guidlines - #171
Conversation
- Add ESLint rule recommendations - Remove all the references to Drupal - Remove things that are obsolete in 2021.
ascott18
commented
Apr 8, 2021
I'd also like to propose a bigger change here - that we rewrite this document entirely as just a list of ESLint rule recommendations, with links to the corresponding ESLint pages that already contain very good descriptions of why the rule is a good idea as well as examples of conforming code and violating code. |
adamskt
left a comment
There was a problem hiding this comment.
Thanks for fixing the newline issues with the code blocks, a lot of the formatting got borked when copying from Google Docs (via Word) to Markdown. I like the idea of referencing ESLint rules for things that line up with the recommendations-- too bad there isn't a linter emojii 😁
This LGTM ![]()
SteveByerly
commented
Apr 8, 2021
It would be even nicer to publish a set of ESLint shareable configurations for different applications (js, ts, vue, react, etc). This docs would then mostly list the rules and link back to their source. |
Steborino
commented
Apr 8, 2021
Agreed about ESLint in general. I suggested a solution back in this Yammer post, but it looks like Shareable Configs is a better implementation of the same idea. |
SteveByerly
left a comment
There was a problem hiding this comment.
Couple of questions, but otherwise looks good to me
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Steve Byerly <1393464+SteveByerly@users.noreply.github.com>
SteveByerly
commented
Apr 8, 2021
Publishing shareable configs based on IntelliTect coding standards was the goal of my tidier repo, but we never did anything with it. |
Uh oh!
There was an error while loading. Please reload this page.