Skip to content

Create Github Build action instead of DevOps Pipeline - #180

Merged
adamskt merged 14 commits into
mainfrom
DevopsToGithubAction
Jul 28, 2021
Merged

Create Github Build action instead of DevOps Pipeline#180
adamskt merged 14 commits into
mainfrom
DevopsToGithubAction

Conversation

@BenjaminMichaelis

@BenjaminMichaelisBenjaminMichaelis commented Jun 1, 2021

Copy link
Copy Markdown
Member

No description provided.

@BenjaminMichaelisBenjaminMichaelis linked an issue Jun 1, 2021 that may be closed by this pull request
Migrate Azure DevOps pipeline to GitHub Action #165
Closed
@BenjaminMichaelisBenjaminMichaelis added the devops Items related to building and deploying label Jun 1, 2021
@BenjaminMichaelisBenjaminMichaelis linked an issue Jun 1, 2021 that may be closed by this pull request
Upgrade build from netcore3.1 to .NET 5.0 #158
Closed
@BenjaminMichaelisBenjaminMichaelis self-assigned this Jun 2, 2021
@BenjaminMichaelisBenjaminMichaelis removed a link to an issue Jun 2, 2021
Upgrade build from netcore3.1 to .NET 5.0 #158
Closed
Keboo
Keboo reviewed Jun 2, 2021
View reviewed changes
Comment thread.github/workflows/dotnet3.1Build.yml Outdated
Comment thread.github/workflows/dotnet3.1Build.yml Outdated
Comment thread.github/workflows/dotnet3.1Build.yml Outdated
Comment thread.github/workflows/dotnet3.1Build.yml Outdated
Comment thread.github/workflows/dotnet3.1Build.yml Outdated
Comment thread.github/workflows/dotnet3.1Build.yml Outdated
Comment thread.github/workflows/dotnet3.1Build.yml Outdated
Comment thread.github/workflows/dotnet3.1Build.yml Outdated
@BenjaminMichaelis

BenjaminMichaelis commented Jun 3, 2021

Copy link
Copy Markdown
MemberAuthor

@Keboo testing seems to be failing because it can't find netcoreapp3.1, not sure on the way to get around this since we wanted to use net5.0 and it doesn't seem to like that currently.

@Keboo

Keboo commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

@BenjaminMichaelis so it looks like it is the actual running of the test project that is failing. This is because even though the .net5 compiler can be used to compile netcore3.1, it doesn't have the runtime bits to actually execute it. Two options (though I think the first is easier):

  1. Update the test project to be net5 (likely need to update the NuGet packages referenced there too)
  2. Install both .net5 and netcore3.1 (sample here)

@BenjaminMichaelisBenjaminMichaelis linked an issue Jun 9, 2021 that may be closed by this pull request
Upgrade build from netcore3.1 to .NET 5.0 #158
Closed
Keboo
Keboo reviewed Jun 9, 2021
View reviewed changes
Comment thread.github/workflows/dotnetBuild.yml Outdated
Comment threadDirectory.Build.props Outdated
Comment threadDirectory.Build.props
MarkMichaelis
MarkMichaelis reviewed Jun 9, 2021
View reviewed changes
Comment threadDirectory.Build.props
@BenjaminMichaelis
BenjaminMichaelis removed the request for review from adamsktJune 10, 2021 19:23
@adamskt
adamskt self-requested a review July 28, 2021 21:31
adamskt
adamskt approved these changes Jul 28, 2021
View reviewed changes

@adamsktadamskt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamskt
adamskt merged commit 118dbd5 into mainJul 28, 2021
@adamskt
adamskt deleted the DevopsToGithubAction branch July 28, 2021 21:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsktadamsktadamskt approved these changes
@MarkMichaelisMarkMichaelisAwaiting requested review from MarkMichaelis
@KebooKebooAwaiting requested review from Keboo

Assignees

@BenjaminMichaelisBenjaminMichaelis

Labels

devopsItems related to building and deploying

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate Azure DevOps pipeline to GitHub Action Upgrade build from netcore3.1 to .NET 5.0

4 participants

@BenjaminMichaelis@Keboo@adamskt@MarkMichaelis