Skip to content

Add Naming Conventions Table - #182

Merged
BenjaminMichaelis merged 9 commits into
IntelliTect:mainfrom
BenjaminMichaelis:NamingConventionsTable
Feb 14, 2022
Merged

Add Naming Conventions Table#182
BenjaminMichaelis merged 9 commits into
IntelliTect:mainfrom
BenjaminMichaelis:NamingConventionsTable

Conversation

@BenjaminMichaelis

Copy link
Copy Markdown
Member

No description provided.

@BenjaminMichaelis

Copy link
Copy Markdown
MemberAuthor

I am not sure how to put this table in the xml to have the md file generated. Also changes do need to be made to the table for sure but it does create the general structure for the vision

@Keboo

Copy link
Copy Markdown
Contributor

In this case I would not put it in the csharp.md file (since that is generated). Instead I would propose we put it, in its own new md file alongside it, and simply add a link to it from the index.md

@BenjaminMichaelis

Copy link
Copy Markdown
MemberAuthor

In this case I would not put it in the csharp.md file (since that is generated). Instead I would propose we put it, in its own new md file alongside it, and simply add a link to it from the index.md

Sure, I guess the worry is that it does make that md file less clean with having documents separate (it would be nice to have everything in one place on one page that is related to a topic, ex: c#).

@Keboo

Copy link
Copy Markdown
Contributor

That is true, but that would mean updating the tool to use some sort of templating mechanism. Because this is useful info, my thought would be just to make is a separate file for now and file a follow up issue to update the tool.

@joeriddles

Copy link
Copy Markdown
Contributor

@BenjaminMichaelis is this ready for review?

@BenjaminMichaelis
BenjaminMichaelis marked this pull request as ready for review July 28, 2021 21:33
@BenjaminMichaelis
BenjaminMichaelis marked this pull request as draft December 29, 2021 22:51
@BenjaminMichaelis
BenjaminMichaelis marked this pull request as ready for review February 9, 2022 01:48
@BenjaminMichaelisBenjaminMichaelis self-assigned this Feb 9, 2022
@BenjaminMichaelisBenjaminMichaelis added the C# coding guidelines Content related to the C# coding guidelines label Feb 9, 2022
@BenjaminMichaelis

Copy link
Copy Markdown
MemberAuthor

@BenjaminMichaelis is this ready for review?

A bit later... and Now it is!

Comment threaddocs/assets/C#NamingGuidelinesTable.md Outdated
Comment threaddocs/assets/C#NamingGuidelinesTable.md Outdated
Comment threaddocs/assets/C#NamingGuidelinesTable.md Outdated
Comment threaddocs/assets/C#NamingGuidelinesTable.md Outdated
Comment threaddocs/assets/C#NamingGuidelinesTable.md Outdated
Comment threaddocs/assets/C#NamingGuidelinesTable.md Outdated
Comment threaddocs/assets/C#NamingGuidelinesTable.md Outdated
BenjaminMichaelisand others added 4 commits February 14, 2022 10:12
Minor changes
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Update docs/assets/C#NamingGuidelinesTable.md
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Update docs/assets/C#NamingGuidelinesTable.md
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Update docs/assets/C#NamingGuidelinesTable.md
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Update docs/assets/C#NamingGuidelinesTable.md
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
@BenjaminMichaelis
BenjaminMichaelis merged commit 615c27c into IntelliTect:mainFeb 14, 2022
@BenjaminMichaelis
BenjaminMichaelis deleted the NamingConventionsTable branch February 14, 2022 19:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# coding guidelinesContent related to the C# coding guidelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@BenjaminMichaelis@Keboo@joeriddles